Skip to content

Fix query param issue when switching tabs - Pipeline schedules refactor

Payton Burdette requested to merge 416571-fix-tab-switching into master

What does this MR do and why?

gl-tabs adds "0" to the query param value when passed null. This resulted in the value being sent up on refresh after being on the All tab and breaking the query. This MR adds a temporary ALL identifier for the all tab query value and removes it before sending the query up. Fixes the bug.

Screenshots or screen recordings

Screenshot_2023-07-05_at_2.31.14_PM

How to set up and validate locally

  1. Enable the feature flag Feature.enable(:pipeline_schedules_vue)
  2. Visit Project > Build > Pipeline schedules
  3. Click the active tab, click back to the all tab
  4. Refresh the page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416571 (closed)

Edited by Payton Burdette

Merge request reports