Skip to content
Snippets Groups Projects

Add "Active runners" to runner fleet dashboard

Merged Miguel Rincon requested to merge 377324-add-dashboard-data into master
All threads resolved!

:warning: This change depends on !125032 (merged), !125034 (merged), !125301 (merged)

What does this MR do and why?

Implements: #377324 (closed)

Note: #377324 (closed) is just one step in the construction of our runner fleet dashboard, so it only contains one panel for now, so the layout is not very interesting yet.

Add runner performance dashboard page

This change adds the runner performance dashboard route as an empty page behind a new feature flag which acts as a placeholder for future development of a runner performance dashboard.

Screenshots or screen recordings

Loading Empty state With results
image image image

How to set up and validate locally

  1. In rails console (rails c) enable the feature

    Feature.enable(:runners_dashboard)
  2. Visit any the admin performance page http://gdk.test:3000/admin/runners/dashboard

    • No page links here yet, we will add that in later MRs.

Verify the empty state

  1. Verify the empty state, you will see it as long as you are not running jobs.

Verify with data

  1. We can seed data into our gdk, but the data seeded may not contain many running jobs, we can add this line to force more running jobs:
diff --git a/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb b/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
index 2cd9afc5bdce..24aacfe01ecd 100644
--- a/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
+++ b/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
@@ -176,6 +176,7 @@ def create_build(pipeline, runner, job_status, index)
           end
 
           def random_pipeline_status
+            return 'running'
             if Random.rand(1..4) == 4
               %w[created pending canceled running].sample
             elsif Random.rand(1..3) == 1
  1. Run bundle exec rake "gitlab:seed:runner_fleet" to generate a mock running jobs.
  2. As an alternative, you can also run a few jobs in instance runners manually
  3. Refresh the page to see the list.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #377324 (closed)

Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • removed database label

  • Miguel Rincon changed milestone to %16.2

    changed milestone to %16.2

  • Miguel Rincon changed the description

    changed the description

    • Author Maintainer
      Resolved by Gina Doyle

      @gdoyle For some reason the UX label is not adding UX reviewers to the roulette, so I'll just go ahead and ask for your review.

      I've made a few additions/changes to your design:

      • added an empty state, feel free to suggest other illustration or text
      • change the header of the table to "Running jobs" to stick with our usual wording

      @fneill can you help me review this one? Thanks!

  • Miguel Rincon requested review from @gdoyle and @fneill

    requested review from @gdoyle and @fneill

  • Author Maintainer

    @thutterer can you help me review this MR? We are waiting on !125032 (merged) but it is already on the last reviews. Thanks!

  • Miguel Rincon requested review from @thutterer

    requested review from @thutterer

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon changed title from Add Active runners to dashboard to Add "Active runners" to runner fleet dashboard

    changed title from Add Active runners to dashboard to Add "Active runners" to runner fleet dashboard

  • Miguel Rincon added 176 commits

    added 176 commits

    • 8e55ea99...b578306a - 166 earlier commits
    • 2c5e3678 - Add dependency review automation
    • d406a7ff - Merge branch 'dependency_review_1' into 'master'
    • 1a2a23de - Show a loading indicator on paste
    • 1e8f87c6 - Merge branch '406724-ce-paste-loading' into 'master'
    • 36578b38 - Add id to EE MR state widget
    • 86bf10cd - Merge branch 'jy-add-id-to-mr-state-div-agai' into 'master'
    • 28bc08be - Merge branch 'jm-zoekt-indexing-project-import' into 'master'
    • bd0bd7b6 - Indicate issue limitations with epics and shared projects
    • 7e3815be - Merge branch 'docs/limations-epics-shared-projects' into 'master'
    • 52bb62bb - Update super siderbar logo import method

    Compare with previous version

  • Miguel Rincon marked this merge request as draft

    marked this merge request as draft

  • Ghost User
  • Ghost User
  • A deleted user added Data WarehouseImpact Check label
  • Miguel Rincon added 3 commits

    added 3 commits

    Compare with previous version

  • Miguel Rincon removed QA label

    removed QA label

  • removed database label

  • Thomas Hutterer removed review request for @thutterer

    removed review request for @thutterer

  • Gina Doyle
  • Miguel Rincon marked this merge request as ready

    marked this merge request as ready

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon added 1 commit

    added 1 commit

    • ef1f77ed - Address reviewer suggestions

    Compare with previous version

  • Fiona Neill approved this merge request

    approved this merge request

  • :wave: @fneill, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Fiona Neill removed review request for @fneill

    removed review request for @fneill

  • Miguel Rincon added 127 commits

    added 127 commits

    Compare with previous version

  • mentioned in issue #417734 (closed)

  • Miguel Rincon requested review from @thutterer

    requested review from @thutterer

  • Miguel Rincon added 1 commit

    added 1 commit

    • 2240b361 - Address reviewer suggestions

    Compare with previous version

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon added 523 commits

    added 523 commits

    Compare with previous version

  • Gina Doyle approved this merge request

    approved this merge request

  • Gina Doyle removed review request for @gdoyle

    removed review request for @gdoyle

  • Pedro Pombeiro deleted the pedropombeiro/377324/1-add-filterByMetrics branch. This merge request now targets the master branch

    deleted the pedropombeiro/377324/1-add-filterByMetrics branch. This merge request now targets the master branch

  • Ghost User
  • Miguel Rincon added 225 commits

    added 225 commits

    Compare with previous version

  • Miguel Rincon resolved all threads

    resolved all threads

  • Miguel Rincon requested review from @vitallium

    requested review from @vitallium

  • Miguel Rincon removed review request for @thutterer

    removed review request for @thutterer

  • mentioned in issue #416763 (closed)

  • Vitaly Slobodin
  • Miguel Rincon added 1 commit

    added 1 commit

    • 2867a49c - Address maintainer suggestions

    Compare with previous version

  • Vitaly Slobodin resolved all threads

    resolved all threads

  • Vitaly Slobodin approved this merge request

    approved this merge request

  • Vitaly Slobodin enabled an automatic merge when the pipeline for eefacafe succeeds

    enabled an automatic merge when the pipeline for eefacafe succeeds

  • Vitaly Slobodin mentioned in commit a18b28ab

    mentioned in commit a18b28ab

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #411005 (closed)

  • Please register or sign in to reply
    Loading