Add "Active runners" to runner fleet dashboard
What does this MR do and why?
Implements: #377324 (closed)
Note: #377324 (closed) is just one step in the construction of our runner fleet dashboard, so it only contains one panel for now, so the layout is not very interesting yet.
Add runner performance dashboard page
This change adds the runner performance dashboard route as an empty page behind a new feature flag which acts as a placeholder for future development of a runner performance dashboard.
Screenshots or screen recordings
Loading | Empty state | With results |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
-
In rails console (
rails c
) enable the featureFeature.enable(:runners_dashboard)
-
Visit any the admin performance page
http://gdk.test:3000/admin/runners/dashboard
- No page links here yet, we will add that in later MRs.
Verify the empty state
- Verify the empty state, you will see it as long as you are not running jobs.
Verify with data
- We can seed data into our gdk, but the data seeded may not contain many running jobs, we can add this line to force more running jobs:
diff --git a/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb b/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
index 2cd9afc5bdce..24aacfe01ecd 100644
--- a/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
+++ b/lib/gitlab/seeders/ci/runner/runner_fleet_pipeline_seeder.rb
@@ -176,6 +176,7 @@ def create_build(pipeline, runner, job_status, index)
end
def random_pipeline_status
+ return 'running'
if Random.rand(1..4) == 4
%w[created pending canceled running].sample
elsif Random.rand(1..3) == 1
- Run
bundle exec rake "gitlab:seed:runner_fleet"
to generate a mock running jobs. - As an alternative, you can also run a few jobs in instance runners manually
- Refresh the page to see the list.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #377324 (closed)
Merge request reports
Activity
changed milestone to %16.4
assigned to @mrincon
- A deleted user
2 Warnings 1227e3af: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
2 Messages CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the
danger-review
job.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ian Anderson (
@imand3r
) (UTC-7, 9 hours behind@mrincon
)John Mason (
@johnmason
) (UTC-4, 6 hours behind@mrincon
)database Mehmet Emin Inac (
@minac
) (UTC+2, same timezone as@mrincon
)Diogo Frazão (
@dfrazao-gitlab
) (UTC+2, same timezone as@mrincon
)frontend James Rushford (
@jrushford
) (UTC+2, same timezone as@mrincon
)Vitaly Slobodin (
@vitallium
) (UTC+2, same timezone as@mrincon
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e0adb5e6
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 39c7c1db and 2867a49c
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.18 MB 4.18 MB -1.93 KB -0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 % New entry points: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.admin.runners.dashboard 0 Bytes 222.31 KB +222.31 KB 100.0 %
Note: We do not have exact data for 39c7c1db. So we have used data from: c89c6aff.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2867a49cexpand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 2867a49cexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 28 | 0 | 3 | 0 | 31 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 19e5e5abexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Verify | 98 | 0 | 10 | 2 | 108 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 98 | 0 | 10 | 2 | 108 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in issue #377324 (closed)
added 529 commits
-
ad3a7360...4edd1631 - 525 commits from branch
master
- b9f808ef - GraphQL: Add MOST_ACTIVE_DESC sort order to runners resolver
- a3ad6e34 - Address MR review comments
- 05c8f650 - Add runner performance dashboard page
- 19e5e5ab - Add Active runners to dashboard
Toggle commit list-
ad3a7360...4edd1631 - 525 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@6fe492a8
mentioned in merge request !125032 (merged)
added 287 commits
-
19e5e5ab...55c2c74a - 284 commits from branch
master
- 3f343648 - GraphQL: Add MOST_ACTIVE_DESC sort order to runners resolver
- 82c4003a - Address MR review comments
- de5a7a8c - Add Active runners to dashboard
Toggle commit list-
19e5e5ab...55c2c74a - 284 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Miguel Rincon
removed database label
changed milestone to %16.2
removed databasereview pending label
removed workflowready for development label
- Resolved by Gina Doyle
@gdoyle For some reason the UX label is not adding UX reviewers to the roulette, so I'll just go ahead and ask for your review.
I've made a few additions/changes to your design:
- added an empty state, feel free to suggest other illustration or text
- change the header of the table to "Running jobs" to stick with our usual wording
@fneill can you help me review this one? Thanks!
@thutterer can you help me review this MR? We are waiting on !125032 (merged) but it is already on the last reviews. Thanks!
requested review from @thutterer
- Resolved by Miguel Rincon
added 176 commits
- 8e55ea99...b578306a - 166 earlier commits
- 2c5e3678 - Add dependency review automation
- d406a7ff - Merge branch 'dependency_review_1' into 'master'
- 1a2a23de - Show a loading indicator on paste
- 1e8f87c6 - Merge branch '406724-ce-paste-loading' into 'master'
- 36578b38 - Add id to EE MR state widget
- 86bf10cd - Merge branch 'jy-add-id-to-mr-state-div-agai' into 'master'
- 28bc08be - Merge branch 'jm-zoekt-indexing-project-import' into 'master'
- bd0bd7b6 - Indicate issue limitations with epics and shared projects
- 7e3815be - Merge branch 'docs/limations-epics-shared-projects' into 'master'
- 52bb62bb - Update super siderbar logo import method
Toggle commit list- A deleted user
added QA database databasereview pending labels
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- A deleted user
added Data WarehouseImpact Check label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f56bcc10
added 3 commits
-
52bb62bb...82c4003a - 2 commits from branch
pedropombeiro/377324/1-add-filterByMetrics
- a8298b49 - Add Active runners to dashboard
-
52bb62bb...82c4003a - 2 commits from branch
removed Data WarehouseImpact Check label
removed databasereview pending label
removed QA label
removed database label
removed documentation label
- Resolved by Gina Doyle
- Resolved by Miguel Rincon
- Resolved by Gina Doyle
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Vitaly Slobodin
Only some small suggestions. Back to you @mrincon
removed review request for @thutterer
- Resolved by Miguel Rincon
added Technical Writing label
@fneill
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @fneill
added 127 commits
-
ef1f77ed...fea857e6 - 125 commits from branch
pedropombeiro/377324/1-add-filterByMetrics
- 1a4fe6ab - Add Active runners to dashboard
- 777b93c0 - Address reviewer suggestions
-
ef1f77ed...fea857e6 - 125 commits from branch
mentioned in issue #417734 (closed)
requested review from @thutterer
added 523 commits
-
2240b361...ebaaa466 - 521 commits from branch
pedropombeiro/377324/1-add-filterByMetrics
- 9ecb3bf7 - Add Active runners to dashboard
- 11e7cba3 - Address reviewer suggestions
-
2240b361...ebaaa466 - 521 commits from branch
removed review request for @gdoyle
- A deleted user
added database databasereview pending documentation labels
- Resolved by Miguel Rincon
added 225 commits
-
11e7cba3...9570d1a3 - 223 commits from branch
master
- 6bf04e02 - Add Active runners to dashboard
- 1227e3af - Address reviewer suggestions
-
11e7cba3...9570d1a3 - 223 commits from branch
requested review from @vitallium
removed review request for @thutterer
mentioned in issue #416763 (closed)
- Resolved by Vitaly Slobodin
- Resolved by Miguel Rincon
- Resolved by Miguel Rincon
- Resolved by Vitaly Slobodin
@mrincon Looks good! Just one question before proceeding. Thanks!
enabled an automatic merge when the pipeline for eefacafe succeeds
mentioned in commit a18b28ab
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue #411005 (closed)