Skip to content

Do not show insights charts with DORA4 metrics for unauthorized users

Felipe Artur requested to merge issue_415023 into master

What does this MR do and why?

Removes dashboard charts that contain DORA metrics for users without REPORTER access. In the case of the dashboard having only unauthorized charts(with DORA) it gets removed from the configuration.

The filter is being applied for insights with custom configuration or default configuration on both projects and groups.

related to https://gitlab.com/gitlab-org/gitlab/-/issues/415023

How to set up and validate locally

Make sure to have an Ultimate license.

With default configuration(for group and project)

  1. Create a group or project
  2. Log in as a guest and go to the left sidebar Analyze -> Insights

Dora4 centralized view chart must not be listed in the dropdown options.

With custom configuration(for group and project)

How to configure insights dashboards for:

  1. Create a group or a project with a custom configuration following the instructions from above.
  2. In the configuration file, make sure to have a dashboard with charts containing data_source: dora
  3. Log in as a guest and go to the left sidebar Analyze -> Insights

All charts configured with data_source: dora should not be visible on the dashboard. If the dashboard contains only DORA charts it should be removed from the dropdown.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Felipe Artur

Merge request reports