Serialize delete refs for Merge Requests to avoid Gitaly deadlock

assigned to @ayufan

added 1 commit

6f981800 - Serialize delete refs for Merge Requests to avoid Gitaly deadlock

Compare with previous version

changed milestone to %16.2

added bugperformance grouptenant scale typebug labels

added devopsdata stores sectioncore platform labels

requested review from @grzesiek

added backend feature flag labels

1 Message

CHANGELOG missing:

If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Piotr Skorupa (`@pskorupa`) (UTC+2, same timezone as `@ayufan`)	Tetiana Chupryna (`@brytannia`) (UTC+2, same timezone as `@ayufan`)
~"Verify"	Reviewer review is optional for ~"Verify"	Drew Cimino (`@drew`) (UTC+0, 2 hours behind `@ayufan`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Sidekiq queue changes

This merge request contains changes to Sidekiq queues. Please follow the documentation on changing a queue's urgency.

These queues were added:

merge_requests_cleanup_ref

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

245eef86 - Serialize delete refs for Merge Requests to avoid Gitaly deadlock

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f79a3756

added 1 commit

0d513abb - Serialize delete refs for Merge Requests to avoid Gitaly deadlock

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@5b08141b

added 1 commit

65e51ced - Serialize delete refs for Merge Requests to avoid Gitaly deadlock

Compare with previous version

mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bc6cce32

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 41d49e0d

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Plan             | 4      | 0      | 0       | 4     | 4     | ❗     |
| Create           | 8      | 0      | 1       | 5     | 9     | ❗     |
| Monitor          | 4      | 0      | 0       | 4     | 4     | ❗     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 13    | 23    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 41d49e0d

expand test summary

+------------------------------------------------------------+
|                       suites summary                       |
+-------+--------+--------+---------+-------+-------+--------+
|       | passed | failed | skipped | flaky | total | result |
+-------+--------+--------+---------+-------+-------+--------+
+-------+--------+--------+---------+-------+-------+--------+
| Total | 0      | 0      | 0       | 0     | 0     | ➖     |
+-------+--------+--------+---------+-------+-------+--------+