Darker and more consistent note backgrounds in dark mode
What does this MR do and why?
Darker and more consistent note backgrounds in dark mode, with higher contrast.
Use $body-bg
for all note wrappers and containers. It is $white
in light mode, and $gray-10
in dark mode. In dark mode $white
is gray-50
, which previously caused the notes to be raised above the background unnecessarily.
Most notable thing recently was the reply area being darker than the notes above, which looked a bit odd.
Should the "Collapse notes" row now be lighter? Yes! It is currently gray-10
soooo not really sure to do about that currently. Thinking about it.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
Only light mode change is removing this small inconsistency in diff notes (light-gray in top, white at the sides):
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Test comments on MRs and Issues
- Also replies
- And diff comments
- And image comments
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.