Skip to content

Dark shadows and overlays in dark mode

Simon Knox requested to merge psimyn-master-patch-00862 into master

What does this MR do and why?

override the mostly-transparent colors in dark mode. Prevents inverting things like modal overlays, and a "glow" effect on shadows.

This is probably too far reaching and some of these things we do want to be lighter colored (dark overlays can potentially be too subtle). But aesthetically this is an improvement over what we currently have, and should really have happened years ago.

Changelog: fixed

Screenshots or screen recordings

Before After
Screenshot_2023-06-29_at_12.29.36 Screenshot_2023-06-29_at_12.28.06

How to set up and validate locally

  1. Enable dark mode
  2. Open some modals (new search bar) and sidebars/drawers.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Simon Knox

Merge request reports