Skip to content

Model files newly returned from gitaly

John Parent requested to merge gitlab-community/gitlab:represent-all-changes-in-MR into master

What does this MR do and why?

Model files newly returned from gitaly

Gitaly's gitaly!5680 (merged) allows for returning information about all files in a diff, not just those that do not exceed file limitations. Add handling for this in Gitlab to request the metadata for diffs that exceed set limits and ensure diff collections process the added metadata as diffs to be stored.

Screenshots or screen recordings

Currently have a bricked GDK (for unreleated and unknown reasons), once it's up I'll attach screenshots. Feel free to forgo review and let me know this is a blocker, in which case I will prioritize obtaining screenshots.

How to set up and validate locally

  1. In rails console enable the experiment fully 
    Feature.enable(:collect_all_diff_paths)
  2. Create an MR that in some way exceeds the diff limitations specified here
  3. Observe that all files, even those that exceeded the limits are represented but not expandable, and the correct counts are present in the changes tab -->

I am unsure if more handling needs to added to the frontend here. I am not well versed with frontend development so any pointers are appreciated!

Edited by John Parent

Merge request reports