Skip to content

Fix NotImplementedError in CreateServiceBase

Fabien Catteau requested to merge fcatteau-master-patch-08424 into master

What does this MR do and why?

NotImplementedError was misspelled in the Vulnerabilities::CreateServiceBase.

This typo doesn't have any consequences.

  • Methods not implemented in the base class are never called.
  • Also, they're not tested.

However, if we introduced a concrete class that inherits from CreateServiceBase without overriding these methods, it would fail b/c NotImplmentedError (typo) isn't found, instead of raising NotImplementedError (correct name).

The behavior doesn't change.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports