Replace a finder class method with a scope
What does this MR do and why?
This MR refactors away a MergeTrains::Car
class method that we don't really need. The Car
querying functionality gets moved out into a scope, and the business function of "refresh all the trains" gets moved into a MergeTrains::Train
method that uses the scope.
The feature this supports is "Refresh all trains in this project", so this flow of logic makes a bit more sense.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #298541 (closed)
Edited by drew stachon