Skip to content

Add columns from approval rules to ScanResultPolicyRead

Sashi Kumar Kumaresan requested to merge sk/416260-move-columns into master

What does this MR do and why?

This MR adds migration to add columns to scan_result_policies table that are currently present in approval_project_rules and approval_merge_request_rules table. This will act as a first step in Use database read model for merge request appr... (&9971)

Migration output

Migrate

VERSION=20230625110317 bundle exec rails db:migrate:main
main: == [advisory_lock_connection] object_id: 229660, pg_backend_pid: 7259
main: == 20230625110317 AddColumnsToScanResultPolicies: migrating ===================
main: -- add_column(:scan_result_policies, :rule_type, :smallint, {:limit=>2, :null=>false, :default=>0})
main:    -> 0.0015s
main: -- add_column(:scan_result_policies, :rule_index, :smallint, {:limit=>2, :null=>false, :default=>0})
main:    -> 0.0006s
main: -- add_column(:scan_result_policies, :vulnerabilities_allowed, :integer, {:limit=>2, :null=>false, :default=>0})
main:    -> 0.0008s
main: -- add_column(:scan_result_policies, :scanners, :text, {:array=>true, :null=>false, :default=>[]})
main:    -> 0.0006s
main: -- add_column(:scan_result_policies, :severity_levels, :text, {:array=>true, :null=>false, :default=>[]})
main:    -> 0.0007s
main: -- add_column(:scan_result_policies, :vulnerability_states, :text, {:array=>true, :null=>false, :default=>["newly_detected"]})
main:    -> 0.0005s
main: == 20230625110317 AddColumnsToScanResultPolicies: migrated (0.0080s) ==========

Rollback

VERSION=20230625110317 bundle exec rails db:rollback:main
main: == [advisory_lock_connection] object_id: 223220, pg_backend_pid: 6237
main: == 20230623073906 PrepareAsyncIndexForCiPipelinesBigintId: reverting ==========
main: == 20230623073906 PrepareAsyncIndexForCiPipelinesBigintId: reverted (0.2714s) =

main: == [advisory_lock_connection] object_id: 223220, pg_backend_pid: 6237

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Addresses #416260 (closed)

Merge request reports