Show pipeline created time in pipeline header
What does this MR do and why?
With the new pipeline header we were only showing pipeline finished time. We got some feedback that the "triggered" time (createdAt) was useful for long running pipelines. This MR adds back the created at time ago for the pipeline as well as keeps the finished time of the pipeline.
I have also added the strings created
and finished
to differentiate these two times since they could get easily confused.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
Finished example
How to set up and validate locally
- Visit project with pipeline
- Run a pipeline, you should see created at time
- Visit finished pipeline, you should see finished time
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #416136 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @pburdette
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- A deleted user
added frontend label
3 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Lorenz van Herwaarden (
@lorenzvanherwaarden
) (UTC+2, 6 hours ahead of@pburdette
)Alexander Turinske (
@aturinske
) (UTC-7, 3 hours behind@pburdette
)test for spec/features/*
Dmytro Biryukov (
@dbiryukov
) (UTC+2, 6 hours ahead of@pburdette
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 7774ce0e and 402d20d8
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.17 MB 4.17 MB - -0.0 % mainChunk 3.09 MB 3.09 MB - 0.0 %
Note: We do not have exact data for 7774ce0e. So we have used data from: 6cc70a4d.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 402d20d8expand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 402d20d8expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 10 | 0 | 0 | 0 | 10 | ✅ | | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 30 | 0 | 3 | 1 | 33 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Jeremy Elder
requested review from @jeldergl
- Resolved by Payton Burdette
@ankit.panchal can you review frontend please?
requested review from @ankit.panchal
- Resolved by Payton Burdette
Can you review @dfrazao-gitlab the test updates please?
requested review from @dfrazao-gitlab
mentioned in issue #416310 (closed)
@jeldergl
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @jeldergl
removed review request for @dfrazao-gitlab
requested review from @bsandlin and removed review request for @ankit.panchal
- Resolved by Payton Burdette
added 853 commits
-
00d9cc24...e624dbbb - 851 commits from branch
master
- dcf1451a - Show pipeline created time
- 3bf29168 - Fix lint error
-
00d9cc24...e624dbbb - 851 commits from branch
removed review request for @bsandlin
- Resolved by Alexander Turinske
@aturinske can you maintain this one please?
requested review from @aturinske
- Resolved by Alexander Turinske
enabled an automatic merge when the pipeline for fe5b232b succeeds
mentioned in commit fabf4046
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
mentioned in merge request !125126 (merged)
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label