Skip to content

Adds padding to details row on the container registry tags list page

What does this MR do and why?

Adds padding to details row on the container registry tags list page.

Why

From !124181 (comment 1441376449), when viewing the details by clicking the details button, the row in the table doesn't look consistent. The first row is 34px and the other two are 41px.

Screenshots or screen recordings

Before After
Screenshot_2023-06-22_at_11.18.04 Screenshot_2023-06-22_at_11.20.13_pm

How to set up and validate locally

  1. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md

  2. In the terminal, run these commands to push images to test base repository & sub repository

    $ docker pull hello-world
    $ docker tag hello-world 127.0.0.1:5000/<project-path> && docker push 127.0.0.1:5000/<project-path>
    $ docker tag hello-world 127.0.0.1:5000/<project-path>/testing && docker push 127.0.0.1:5000/<project-path>/testing
    $ docker tag hello-world 127.0.0.1:5000/<project-path>/testing/hello-world && docker push 127.0.0.1:5000/<project-path>/testing/hello-world
  3. Visit the container registry list page for the project

  4. Visit the detail page for any of the images.

  5. Select the horizontal ellipsis icon, should open details row

  6. The height of all the rows should be consistent

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #410503 (closed)

Merge request reports

Loading