Remove dismissal_reason feature flag
What does this MR do and why?
Remove the dismissal_reason
feature flag.
The feature has been enabled by default for just under 2 months.
Related to #398717 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #398717 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @thiagocsf
- Resolved by Ezekiel Kigbo
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Minahil Nichols (
@minahilnichols
) (UTC-4, 14 hours behind@thiagocsf
)Charlie Ablett (
@cablett
) (UTC+12, 2 hours ahead of@thiagocsf
)frontend Scott de Jonge (
@sdejonge
) (UTC+10, same timezone as@thiagocsf
)Ezekiel Kigbo (
@ekigbo
) (UTC+10, same timezone as@thiagocsf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@eddc9924
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c5f1980d and f37b06c1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB - -0.0 % mainChunk 3 MB 3 MB - 0.0 %
Note: We do not have exact data for c5f1980d. So we have used data from: c8a461ec.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f4b69d40
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for f37b06c1expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 2 | 0 | 0 | 0 | 2 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for f37b06c1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Govern | 20 | 0 | 1 | 0 | 21 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 38 | 0 | 4 | 1 | 42 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for f37b06c1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 151 | 0 | 19 | 2 | 170 | ❗ | | Govern | 196 | 1 | 12 | 0 | 209 | ❌ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 369 | 1 | 33 | 2 | 403 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
requested review from @minahilnichols and @lorenzvanherwaarden
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@55d50fe8
- Resolved by Thiago Figueiró
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cc2d5abe
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@48e2319a
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@51623e9c
@lorenzvanherwaarden
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9f4d2d73
requested review from @cablett and removed review request for @minahilnichols
requested review from @ekigbo
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@7105899d
added 657 commits
-
c0e50a79...c5f1980d - 656 commits from branch
master
- f37b06c1 - Remove dismissal_reason feature flag
-
c0e50a79...c5f1980d - 656 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@3e5745a5
enabled an automatic merge when the pipeline for 3e5745a5 succeeds
mentioned in commit 320a5b1a
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label