Skip to content

Align repository_resolver signature for DESIGN repo type

Aakriti Gupta requested to merge ag-align-repository-resolver into master

What does this MR do and why?

Gitlab::GlRepository allows you to get the repositories depending on the repo type, e.g. project, wiki, snippet, design.

e.g. you can get a snippet repo by calling: Gitlab::GlRepository::DESIGN.repository_for(snippet).

The repository_resolver param used to create the new object is usually an object of the repo type itself. But for designs, it is a project.

This MR re-factors for consistency, so that to get a project's design repo we call Gitlab::GlRepository::DESIGN.repository_for(project.design_management_repository) instead of Gitlab::GlRepository::DESIGN.repository_for(project).

It gets rid of some of the workarounds introduced in !118510 (diffs)

Resolves #407542 (closed) and #409454 (closed)

Screenshots or screen recordings

How to set up and validate locally

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Aakriti Gupta

Merge request reports