Product analytics settings use combined_analytics_dashboards instead
requested to merge 415065-group-project-analytics-settings-are-tied-to-the-product-analytics-feature-flag into master
What does this MR do and why?
This MR updates:
- Group settings to only show the Analytics Dashboards subsection when the
:combined_analytics_dashboards
feature flag is enabled. - Project settings to only show the Analytics section when the
:combined_analytics_dashboards
feature flag is enabled.- Once we show more than one subsection under Analytics this check could be moved to the Analytics Dashboards subsection as with groups.
- Creates a new groups helper to check that the subsection can be shown.
- Updates the helpers names to distinguish between the groups and projects helpers.
Flag off
Group settings
Before | After |
---|---|
![]() |
![]() |
Project settings
Before | After |
---|---|
![]() |
![]() |
Flag on
No visual changes
Group settings
Before | After |
---|---|
![]() |
![]() |
Project settings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Follow these instructions to set up Product Analytics in your GDK.
- With the feature flag disabled:
- Go to the group settings:
[GDK_HOST]/groups/[GROUP_NAME]/-/edit
. - Expand Analytics and confirm that the Analytics Dashboards subsection is not shown.
- Go to the project settings:
[GDK_HOST]/[GROUP_NAME]/[PROJECT_NAME]/edit
. - Confirm that the Analytics section is not shown.
- Go to the group settings:
- Enable the feature flag:
echo "Feature.enable(:combined_analytics_dashboards)" | rails c
- With the feature flag enabled:
- Go to the group settings:
[GDK_HOST]/groups/[GROUP_NAME]/-/edit
. - Expand Analytics and confirm that the Analytics Dashboards subsection is shown.
- Go to the project settings:
[GDK_HOST]/[GROUP_NAME]/[PROJECT_NAME]/edit
. - Confirm that the Analytics section is shown.
- Go to the group settings:
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415065 (closed)
Edited by Robert Hunt