Fix flaky spec for update_service_spec.rb
What does this MR do and why?
This MR resolves: gitlab-org/quality/engineering-productivity/master-broken-incidents#2797 (closed)
The cause: Removed service call from specs
The fix: Call the service
MR that introduced the issue: !123933 (merged)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @mhamda
added devopsfulfillment sectionfulfillment labels
requested review from @cwiesner
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Smriti Garg (
@sgarg_gitlab
) (UTC+5.5, 3.5 hours ahead of@mhamda
)Douglas Barbosa Alexandre (
@dbalexandre
) (UTC+0, 2 hours behind@mhamda
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerThanks @mhamda for the quick fix to address the flaky spec. This looks good to me and I verified locally that it's working as expected. Makes me wonder how this passed in the MR though?
Anyway, approving from my side.
Oh sorry @cwiesner, just saw your first question:
Answer: I don't really know, but what I believe is that the params passed contain the limit history and it updates the record when it's running as a file! when it's running each example individually it fails because the service was not invoked, could be related to
.send
?.I am not sure if master pipelines run each example individually or not, but it could be
I will definitely check that because I still wonder why it was passing in the MR itself.
Edited by Mohamed Hamdaspecs are run in a random order especially to highlight problems like this
(although the docs imply it's only new spec files, I'm not sure that's the case )Edited by Vijay HawoldarThat's a really nice link, thanks for sharing it Vij.
@cwiesner Should we create an issue? The Changes are straightforward !93137 (diffs)
Edited by Mohamed Hamda@mhamda, yes let's create an issue. Do you mind taking care of that?
Sure, here we go https://gitlab.com/gitlab-org/customers-gitlab-com/-/issues/6812
Please feel free to add any more details.
It's good @mhamda, thanks for creating it
changed milestone to %16.2
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@mhamda - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
added maintenancetest-gap typemaintenance labels
removed review request for @cwiesner
requested review from @vij
enabled an automatic merge when the pipeline for 9a6c8526 succeeds
enabled an automatic merge when the pipeline for 38d75cce succeeds
mentioned in commit d016dbbe
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label