Skip to content

Move `vendor/gems/ipynbdiff` into `gems/gitlab-ipynbdiff`

Eduardo Bonet requested to merge 415888-move-vendor-gems-ipynbdiff-into-gems into master

What does this MR do and why?

Move ipynbdiff gem into gems folder, instead of vendor/gems (https://docs.gitlab.com/ee/development/gems.html). Some refactoring was necessary because of the added rubocop rules.

How to set up and validate locally

Tests passing should already be enough. If you want to test if the features works:

  1. Navigate to gitlab/test
  2. Select the branch 'add-ipython-files'
  3. Open commit gitlab-test/-/commit/5cf305540efcc3f4dd6476df1f551095a269864d
  4. Verify the the rendered diff shows up:

image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #415888 (closed)

Edited by Eduardo Bonet

Merge request reports