Skip to content

Add ordering to the git_rate_limit_users_alertlist API call

Alex Buijs requested to merge add-ordering-to-git_rate_limit_users_alertlist-api into master

What does this MR do and why?

This adds ordering to the git_rate_limit_users_alertlist field of the application/settings API call.

Issue: #415588

How to set up and validate locally

  1. Login as admin
  2. Create a PAT on http://localhost:3000/-/profile/personal_access_tokens with api scope
  3. Go to http://localhost:3000/admin/application_settings/reporting
  4. Expand the Git abuse rate limit section
  5. Add some users to the Send notifications to field
  6. Verify the resulting array of integers when calling the API is ordered 
    curl -s -H "PRIVATE-TOKEN: ${PAT}" http://localhost:3000/api/v4/application/settings | jq -c .git_rate_limit_users_alertlist

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alex Buijs

Merge request reports