Draft: Fix behavior of getHttpString helper
What does this MR do and why?
Fix the behaviour of getHttpString
helper, so it is aligned with the current modal.
The helper function should return an empty string if the result does not include all the following values:
- Method or status code
- URL or reason phrase
- Headers
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
current modal | new modal before | new modal after |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @dpisek
- A deleted user
added frontend label
3 Warnings This merge request does not refer to an existing milestone. Please add a merge request subtype to this merge request. Please add a merge request type to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ross Byrne (
@robyrne
) (UTC+1, 1 hour behind@dpisek
)Andrew Fontaine (
@afontaine
) (UTC-4, 6 hours behind@dpisek
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @dpisek - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits eaafe868 and 867dc444
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for eaafe868. So we have used data from: 5cd8abbf.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 867dc444expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 867dc444expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 6 | 2 | 1 | 1 | 9 | ❌ | | Plan | 2 | 1 | 1 | 0 | 4 | ❌ | | Govern | 18 | 2 | 1 | 0 | 21 | ❌ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 33 | 5 | 4 | 1 | 42 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
Setting label groupthreat insights based on
@dpisek
's group.added groupthreat insights label
Setting label(s) Category:Software Bill of Materials devopsgovern sectionsec based on groupthreat insights.
added Category:Software Bill of Materials devopsgovern sectionsec labels
added 490 commits
-
29d7183f...db3260ae - 489 commits from branch
master
- 5b524aa7 - Fix behavior of getHttpString helper
-
29d7183f...db3260ae - 489 commits from branch
added 235 commits
-
5b524aa7...8aff4bf8 - 234 commits from branch
master
- d1b26afe - Fix behavior of getHttpString helper
-
5b524aa7...8aff4bf8 - 234 commits from branch
added 47 commits
-
d1b26afe...3a841e89 - 46 commits from branch
master
- 867dc444 - Fix behavior of getHttpString helper
-
d1b26afe...3a841e89 - 46 commits from branch
37 37 const urlOrReasonPhrase = url || reasonPhrase; 38 38 const headerString = headers.map(({ name, value }) => `${name}: ${value}`).join('\n'); 39 39 40 if (!methodOrStatusCode || !urlOrReasonPhrase || !headerString) { note: since this helper's behaviour should be aligned with existing functionality, I've added this check. See details component that is used by the current modal: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_details.vue#L216