Skip to content
Snippets Groups Projects

Draft: Fix behavior of getHttpString helper

Closed David Pisek requested to merge dpisek-fix-behavior-of-get-http-string into master
2 unresolved threads

What does this MR do and why?

Fix the behaviour of getHttpString helper, so it is aligned with the current modal.

The helper function should return an empty string if the result does not include all the following values:

  • Method or status code
  • URL or reason phrase
  • Headers

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

current modal new modal before new modal after
Screenshot_2023-06-26_at_4.01.40_pm Screenshot_2023-06-26_at_4.03.57_pm Screenshot_2023-06-26_at_4.04.30_pm

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by David Pisek

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
37 37 const urlOrReasonPhrase = url || reasonPhrase;
38 38 const headerString = headers.map(({ name, value }) => `${name}: ${value}`).join('\n');
39 39
40 if (!methodOrStatusCode || !urlOrReasonPhrase || !headerString) {
  • David Pisek changed the description

    changed the description

  • Author Maintainer

    Closing this because the behaviour actually differs between the request- and response fields.

  • closed

  • Please register or sign in to reply
    Loading