Skip to content

Ensure gems directory is linted with Gemspec/AvoidExecutingGit

Stan Hu requested to merge sh-lint-gems-dir into master

What does this MR do and why?

Previously we only checked vendor/gems for invocations of git in the gemspec files. !121676 (merged) introduced the gems directory, so we should lint this directory as well.

Relates to #415739 (closed)

How to set up and validate locally

  1. Run scripts/lint-vendored-gems.sh. It should pass.
  2. Revert !124141 (merged).
  3. Run scripts/lint-vendored-gems.sh again. It should now fail.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports