Show Popover on Epic links within Markdown
What does this MR do and why?
This MR adds support for showing Popover on Epic links within Markdown similar to how we show it for Issue and MR links.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Popover | |
---|---|
With Dates | ![]() |
Without Dates (Also confidential) | ![]() |
Long Reference | ![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Make sure you have a group with an epic present.
- Go to any Issue/MR description or comment markdown and paste link to an epic and save the markdown.
- Hover over the epic link on rendered markdown and it should show a popover as shown in MR description.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415652 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @kushalpandya
3 Warnings This merge request is quite big (690 lines changed), please consider splitting it into multiple merge requests. featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
This merge request changed files with disabled eslint rules. Please consider fixing them. Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:ee/app/assets/javascripts/epics_list/components/epics_list_root.vue
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'ee/app/assets/javascripts/epics_list/components/epics_list_root.vue'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Minahil Nichols (
@minahilnichols
) (UTC-4, 9.5 hours behind@kushalpandya
)Luke Duncalfe (
@.luke
) (UTC+12, 6.5 hours ahead of@kushalpandya
)frontend Elwyn Benson (
@elwyn-gitlab
) (UTC+12, 6.5 hours ahead of@kushalpandya
)Coung Ngo (
@cngo
) (UTC+1, 4.5 hours behind@kushalpandya
)UX Libor Vanc (
@lvanc
) (UTC-10, 15.5 hours behind@kushalpandya
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Kushal Pandya
requested review from @andlovu
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a1f7a04d and daa34e71
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB +1.03 KB 0.0 % mainChunk 2.99 MB 2.99 MB +1.03 KB 0.0 %
Note: We do not have exact data for a1f7a04d. So we have used data from: 69f88c32.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for daa34e71expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for daa34e71expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 50 | 0 | 1 | 0 | 51 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 67 | 0 | 3 | 1 | 70 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
@andlovu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added 626 commits
-
7c74da78...088d1f01 - 625 commits from branch
master
- 10e73348 - Show Popover on Epic links within Markdown
-
7c74da78...088d1f01 - 625 commits from branch
requested review from @arfedoro
- Resolved by Coung Ngo
- Resolved by Coung Ngo
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
requested review from @digitalmoksha
removed review request for @digitalmoksha
- Resolved by Coung Ngo
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
added 239 commits
-
36a92413...a6015fb7 - 238 commits from branch
master
- daa34e71 - Show Popover on Epic links within Markdown
-
36a92413...a6015fb7 - 238 commits from branch
enabled an automatic merge when the pipeline for 2e3e9fb2 succeeds
mentioned in commit 5cd8abbf
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #415652 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label