Skip to content

Remove metric related unused routes from project file

Rajendra Kadam requested to merge 397138-remove-unused-routes into master

What does this MR do and why?

Relates to removals mentioned in #397138 (closed)

Address comment - !122055 (comment 1419054097)

Screenshots or screen recordings

NA

How to set up and validate locally

  1. End points for Prometheus API proxy is removed. So that endpoint should return 404.
  2. Metrics endpoint for project namespace should return 404. Endpoints - metrics/:dashboard_path/.
  3. Endpoint for creating new metrics panel should also return 404.
  4. Earlier /-/metrics endpoint on project returned 500 for non existence of controller, now it should return 404.

Rest of the changes revolve around specs for fixing the usage of these endpoints using GitlabRoutingHelper.

While removing the above usages for endpoints, I also had to update the entity code that returned URL to metrics page.

And I had to update some json fixtures to match the new entity schema.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #397138 (closed)

Edited by Vitali Tatarintev

Merge request reports