Migrate job retry dropdown to GlDisclosureDropdown
requested to merge gitlab-community/gitlab:413464-migrate-job-sidebar-retry-dropdown-to-disclosure into master
What does this MR do and why?
Migrate GlDropdown to GlDisclosureDropdown on app/assets/javascripts/jobs/components/job/sidebar/job_sidebar_retry_button.vue
Changelog: changed
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Open any failed job on any of the existing projects from the jobs page (
/flightjs/Flight/-/jobs) - Apply the followin patch to
job_sidebar_retry_button.vue
===================================================================
--- a/app/assets/javascripts/jobs/components/job/sidebar/job_sidebar_retry_button.vue (revision f46e8d89fa3558bd59061067a347003a8297b604)
+++ b/app/assets/javascripts/jobs/components/job/sidebar/job_sidebar_retry_button.vue (date 1687101567209)
@@ -51,7 +51,7 @@
</script>
<template>
<gl-button
- v-if="hasForwardDeploymentFailure"
+ v-if="false"
v-gl-modal="modalId"
:aria-label="$options.i18n.retryJobLabel"
category="primary"
@@ -60,7 +60,7 @@
data-testid="retry-job-button"
/>
<gl-disclosure-dropdown
- v-else-if="isManualJob"
+ v-else-if="true"
icon="retry"
category="primary"
placement="right"MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413464 (closed)
Edited by Shane Maglangit