Upgrade Rails to 7.0.5
What does this MR do and why?
This MR:
- Upgrades the Rails gem version to 7.0.5
- Removes patches that were merged upstream
Merge request reports
Activity
changed milestone to %16.1
assigned to @igor.drozdov
added devopscreate sectiondev labels
- A deleted user
added database databasereview pending frontend labels
1 Warning This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregory Havenga (
@ghavenga
) (UTC+2, same timezone as@igor.drozdov
)Mehmet Emin Inac (
@minac
) (UTC+2, same timezone as@igor.drozdov
)frontend Stanislav Lashmanov (
@slashmanov
) (UTC+4, 2 hours ahead of@igor.drozdov
)Andrew Fontaine (
@afontaine
) (UTC-4, 6 hours behind@igor.drozdov
)test for spec/features/*
Gregory Havenga (
@ghavenga
) (UTC+2, same timezone as@igor.drozdov
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
Rubygems
This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5de33773 and 5d65bab9
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for 5de33773. So we have used data from: 53e936a1.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 5d65bab9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 5d65bab9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 2 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 5d65bab9expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Package | 233 | 0 | 46 | 24 | 279 | ❗ | | Plan | 318 | 0 | 3 | 0 | 321 | ✅ | | Create | 693 | 0 | 107 | 10 | 800 | ❗ | | Fulfillment | 10 | 0 | 100 | 0 | 110 | ✅ | | Secure | 8 | 0 | 36 | 0 | 44 | ✅ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | Verify | 196 | 0 | 20 | 4 | 216 | ❗ | | Govern | 193 | 0 | 12 | 0 | 205 | ✅ | | Release | 24 | 0 | 0 | 0 | 24 | ✅ | | Data Stores | 151 | 0 | 3 | 0 | 154 | ✅ | | Monitor | 44 | 0 | 9 | 0 | 53 | ✅ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | Manage | 174 | 1 | 31 | 10 | 206 | ❌ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | | Systems | 2 | 0 | 0 | 0 | 2 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2058 | 1 | 398 | 48 | 2457 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added 6 commits
- bbe94f41 - Upgrade Rails to 7.0.5
- 6f888202 - Remove Action Cable Listener patch
- a68fd22b - Remove Activerecord Postgresql Timestamp patch
- 5d82364c - Fix counting by enum type
- 8d2f98da - Expect Bad Request (400) instead of 500 for failed multipart requests
- 2e936c5e - Upgrade gettext_i18n_rails gem to 1.11.0
Toggle commit listmentioned in epic &7875 (closed)
changed milestone to %16.2
added missed:16.1 label
added 467 commits
-
2e936c5e...f979a123 - 461 commits from branch
master
- 35741af5 - Upgrade Rails to 7.0.5
- 93a7d806 - Remove Action Cable Listener patch
- b6eb2136 - Remove Activerecord Postgresql Timestamp patch
- 63bd9d13 - Fix counting by enum type
- db75f10c - Expect Bad Request (400) instead of 500 for failed multipart requests
- 2d503d7e - Fix a typo
Toggle commit list-
2e936c5e...f979a123 - 461 commits from branch
removed databasereview pending label
removed database label
removed frontend label
removed missed:16.1 label
mentioned in issue gitlab-com/gl-infra/delivery#19286 (closed)
- Resolved by Thong Kuah
@engwan @splattael @tkuah since 7.0.4.3 is merged and deployed, let's review/merge this MR
Could you please have a look?