Skip to content
Snippets Groups Projects

Do not allow emails with trailing spaces to be added as invites

Merged Doug Stull requested to merge 414749-fix-invite-token into master
All threads resolved!

What does this MR do and why?

:notebook: This change takes the approach of preventing a situation that causes a bug by not allowing user defined tokens for emails with leading or trailing spaces.

Do not allow emails with trailing spaces to be added as invites see https://gitlab.com/gitlab-org/gitlab/-/issues/414749#note_1433106116

  • keeps us out of incorrect error reporting in the dom as seen below snapshot of current master behavior when email with spaces are used.

Screenshot_2023-06-16_at_12.04.21_PM

Changelog: fixed

Screenshots or screen recordings

Before After
Screenshot_2023-06-16_at_1.01.23_PM Screenshot_2023-06-16_at_12.57.43_PM

How to set up and validate locally

  1. Visit any group or project that your user is owner/maintainer of.
  2. On the members page, click 'Invite members'
  3. Attempt to simulate scenario in screenshots on before(master) and now.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414749

Edited by Doug Stull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Doug Stull
  • Doug Stull
  • Doug Stull
  • Doug Stull marked this merge request as ready

    marked this merge request as ready

  • Doug Stull marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Doug Stull added workflowin review label and removed workflowin dev label

    added workflowin review label and removed workflowin dev label

  • Doug Stull requested review from @annabeldunstone

    requested review from @annabeldunstone

  • Doug Stull requested review from @robyrne

    requested review from @robyrne

  • Doug Stull requested review from @mfluharty

    requested review from @mfluharty

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for d80ecee2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Create           | 8      | 0      | 1       | 6     | 9     | ❗     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Monitor          | 4      | 0      | 0       | 4     | 4     | ❗     |
    | Plan             | 4      | 0      | 0       | 3     | 4     | ❗     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 13    | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :exclamation: test report for d80ecee2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Create           | 8      | 0      | 1       | 1     | 9     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • removed review request for @annabeldunstone

  • :wave: @annabeldunstone, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Ross Byrne approved this merge request

    approved this merge request

  • Ross Byrne requested review from @minac and removed review request for @robyrne

    requested review from @minac and removed review request for @robyrne

  • Mehmet Emin INAC approved this merge request

    approved this merge request

  • Mehmet Emin INAC removed review request for @minac

    removed review request for @minac

  • Miranda Fluharty approved this merge request

    approved this merge request

  • Miranda Fluharty requested review from @cngo and removed review request for @mfluharty

    requested review from @cngo and removed review request for @mfluharty

  • 🤖 GitLab Bot 🤖 changed milestone to %16.2

    changed milestone to %16.2

  • Coung Ngo
  • Coung Ngo resolved all threads

    resolved all threads

  • Coung Ngo approved this merge request

    approved this merge request

  • Coung Ngo enabled an automatic merge when the pipeline for 63456beb succeeds

    enabled an automatic merge when the pipeline for 63456beb succeeds

  • merged

  • Coung Ngo mentioned in commit dc149a1a

    mentioned in commit dc149a1a

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading