Do not allow emails with trailing spaces to be added as invites
What does this MR do and why?
Do not allow emails with trailing spaces to be added as invites see https://gitlab.com/gitlab-org/gitlab/-/issues/414749#note_1433106116
- keeps us out of incorrect error reporting in the dom as seen below snapshot of current master behavior when email with spaces are used.
Changelog: fixed
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Visit any group or project that your user is owner/maintainer of.
- On the members page, click 'Invite members'
- Attempt to simulate scenario in screenshots on before(master) and now.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #414749
Merge request reports
Activity
changed milestone to %16.1
added Next Up bugux devopsgrowth groupacquisition priority4 sectiongrowth severity4 typebug workflowin dev + 1 deleted label
assigned to @dstull
@dstull Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
- A deleted user
added frontend label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ross Byrne (
@robyrne
) (UTC+1, 5 hours ahead of@dstull
)Vitali Tatarintev (
@ck3g
) (UTC+2, 6 hours ahead of@dstull
)frontend James Rushford (
@jrushford
) (UTC+2, 6 hours ahead of@dstull
)Vitaly Slobodin (
@vitallium
) (UTC+2, 6 hours ahead of@dstull
)test for spec/features/*
Ross Byrne (
@robyrne
) (UTC+1, 5 hours ahead of@dstull
)Maintainer review is optional for test for spec/features/*
UX Kevin Comoli (
@kcomoli
) (UTC+2, 6 hours ahead of@dstull
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits ea360037 and d80ecee2
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for ea360037. So we have used data from: 04f47f21.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- d80ecee2 - Do not allow emails with trailing spaces to be added as invites
- A deleted user
added backend label
removed backend label
added UX label
- A deleted user
added backend label
- Resolved by Coung Ngo
- Resolved by Coung Ngo
- Resolved by Coung Ngo
- Resolved by Coung Ngo
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Coung Ngo
@annabeldunstone can you review UX?
added workflowin review label and removed workflowin dev label
requested review from @annabeldunstone
- Resolved by Mehmet Emin INAC
requested review from @robyrne
- Resolved by Coung Ngo
@mfluharty can you review frontend?
requested review from @mfluharty
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d80ecee2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for d80ecee2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
removed review request for @annabeldunstone
@annabeldunstone
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @minac
requested review from @cngo and removed review request for @mfluharty
changed milestone to %16.2
added missed:16.1 label
- Resolved by Coung Ngo
enabled an automatic merge when the pipeline for 63456beb succeeds
mentioned in commit dc149a1a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label