Skip to content

Fix "empty" approval rules when user_ids or group_ids provided

What does this MR do and why?

Contributes to #415431 (closed)

Problem

Grape v1.7.0 introduced a change to parameter renaming functionality. https://github.com/ruby-grape/grape/blob/master/UPGRADING.md#upgrading-to--160

Grape update issue: #395809 (closed)

With out previous configuration it was possible to send user_ids and group_ids as parameters. But after the gem upgrade this configuration became invalid and prevents us from accessing user_ids and group_ids.

Solution

Explicitly add a parameter definition for user_ids and group_ids. It will permit us to set user_ids and group_ids in the query.

How to set up and validate locally

  1. See steps to reproduce: #415431 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Vasilii Iakliushin

Merge request reports