Remove progress bar during subscriptions
What does this MR do and why?
- Removes the progress bar from last step in subscription registrations
- at some point in time the progress bar was removed from all steps on subscription registration except the group creation step. We'll fix that here. See further discussion in #414736 (closed)
- Moves
WelcomeHelper
to proper code path as there is no foss counterpart. - Resolve some rubocop exceptions on files touched.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Setup to simulate SaaS and restart GDK
- Visit a group's subscription page like
/-/subscriptions/groups/flightjs/edit
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #414736 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @dstull
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hitesh Raghuvanshi (
@hraghuvanshi
) (UTC+5.5, 9.5 hours ahead of@dstull
)Dylan Griffith (
@DylanGriffith
) (UTC+10, 14 hours ahead of@dstull
)frontend Payton Burdette (
@pburdette
) (UTC-4, same timezone as@dstull
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 7 hours ahead of@dstull
)UX Julia Miocene (
@jmiocene
) (UTC+2, 6 hours ahead of@dstull
)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
- Resolved by Anna Vovchenko
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d79a215b and 4f3fcf2e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.12 MB 4.12 MB - -0.0 % mainChunk 3 MB 3 MB - 0.0 % Significant Reduction: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.subscriptions.groups.edit 12.57 KB 9.39 KB -3.18 KB -25.3 %
Note: We do not have exact data for d79a215b. So we have used data from: e5b5d55a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded UX label
- Resolved by Anna Vovchenko
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
added workflowin review label and removed workflowin dev label
- Resolved by Anna Vovchenko
@pburdette can you review frontend?
- Resolved by Anna Vovchenko
@rliu-int can you review backend?
requested review from @rliu-int and @pburdette
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @jmiocene
- Resolved by Roy Liu
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 4f3fcf2eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 4f3fcf2eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 3 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 4f3fcf2eexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Fulfillment | 12 | 0 | 125 | 0 | 137 | ✅ | | Package | 265 | 3 | 49 | 228 | 317 | ❌ | | Create | 688 | 0 | 117 | 5 | 805 | ❗ | | Govern | 243 | 2 | 10 | 5 | 255 | ❌ | | Plan | 390 | 0 | 3 | 0 | 393 | ✅ | | Manage | 209 | 16 | 17 | 29 | 242 | ❌ | | Data Stores | 185 | 0 | 3 | 0 | 188 | ✅ | | Verify | 249 | 1 | 25 | 0 | 275 | ❌ | | Monitor | 52 | 0 | 11 | 0 | 63 | ✅ | | Release | 30 | 0 | 0 | 0 | 30 | ✅ | | Growth | 0 | 0 | 10 | 0 | 10 | ➖ | | Configure | 1 | 0 | 15 | 0 | 16 | ✅ | | Secure | 10 | 0 | 45 | 0 | 55 | ✅ | | Systems | 19 | 0 | 0 | 0 | 19 | ✅ | | Analytics | 11 | 0 | 0 | 0 | 11 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Framework sanity | 0 | 0 | 7 | 0 | 7 | ➖ | | ModelOps | 0 | 0 | 5 | 0 | 5 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2366 | 22 | 443 | 267 | 2831 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
@rliu-int
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @mayra-cabrera and removed review request for @rliu-int
removed review request for @mayra-cabrera
requested review from @anna_vovchenko
removed review request for @pburdette
mentioned in issue #414033 (closed)
enabled an automatic merge when the pipeline for a3956bcf succeeds
@dstull Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run thee2e:package-and-test-ee
job in theqa
stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
added pipeline:run-all-e2e label
mentioned in commit 3ddf1a86
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label