Skip to content
Snippets Groups Projects

Remove progress bar during subscriptions

All threads resolved!

What does this MR do and why?

  • Removes the progress bar from last step in subscription registrations
    • at some point in time the progress bar was removed from all steps on subscription registration except the group creation step. We'll fix that here. See further discussion in #414736 (closed)
  • Moves WelcomeHelper to proper code path as there is no foss counterpart.
  • Resolve some rubocop exceptions on files touched.

Screenshots or screen recordings

Before After
Screenshot_2023-06-07_at_2.45.34_PM Screenshot_2023-06-14_at_3.33.05_PM

How to set up and validate locally

  1. Setup to simulate SaaS and restart GDK
  2. Visit a group's subscription page like /-/subscriptions/groups/flightjs/edit

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414736 (closed)

Edited by Doug Stull

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Doug Stull
  • Doug Stull
  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits d79a215b and 4f3fcf2e

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.12 MB 4.12 MB - -0.0 %
    mainChunk 3 MB 3 MB - 0.0 %

    :tada: Significant Reduction: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.subscriptions.groups.edit 12.57 KB 9.39 KB -3.18 KB -25.3 %

    Note: We do not have exact data for d79a215b. So we have used data from: e5b5d55a.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Doug Stull marked this merge request as ready

    marked this merge request as ready

  • Doug Stull added UX label

    added UX label

  • Doug Stull added workflowin review label and removed workflowin dev label

    added workflowin review label and removed workflowin dev label

  • Doug Stull requested review from @rliu-int and @pburdette

    requested review from @rliu-int and @pburdette

  • Doug Stull marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • A deleted user added backend frontend labels

    added backend frontend labels

  • Doug Stull requested review from @jmiocene

    requested review from @jmiocene

  • Doug Stull changed the description

    changed the description

  • Roy Liu
  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 4f3fcf2e

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: :exclamation: test report for 4f3fcf2e

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 3       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 4f3fcf2e

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Fulfillment      | 12     | 0      | 125     | 0     | 137   | ✅     |
    | Package          | 265    | 3      | 49      | 228   | 317   | ❌     |
    | Create           | 688    | 0      | 117     | 5     | 805   | ❗     |
    | Govern           | 243    | 2      | 10      | 5     | 255   | ❌     |
    | Plan             | 390    | 0      | 3       | 0     | 393   | ✅     |
    | Manage           | 209    | 16     | 17      | 29    | 242   | ❌     |
    | Data Stores      | 185    | 0      | 3       | 0     | 188   | ✅     |
    | Verify           | 249    | 1      | 25      | 0     | 275   | ❌     |
    | Monitor          | 52     | 0      | 11      | 0     | 63    | ✅     |
    | Release          | 30     | 0      | 0       | 0     | 30    | ✅     |
    | Growth           | 0      | 0      | 10      | 0     | 10    | ➖     |
    | Configure        | 1      | 0      | 15      | 0     | 16    | ✅     |
    | Secure           | 10     | 0      | 45      | 0     | 55    | ✅     |
    | Systems          | 19     | 0      | 0       | 0     | 19    | ✅     |
    | Analytics        | 11     | 0      | 0       | 0     | 11    | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Framework sanity | 0      | 0      | 7       | 0     | 7     | ➖     |
    | ModelOps         | 0      | 0      | 5       | 0     | 5     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 2366   | 22     | 443     | 267   | 2831  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Doug Stull added 1 commit

    added 1 commit

    Compare with previous version

  • Doug Stull added 1 commit

    added 1 commit

    Compare with previous version

  • Doug Stull added 1 commit

    added 1 commit

    Compare with previous version

  • Roy Liu approved this merge request

    approved this merge request

  • :wave: @rliu-int, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Roy Liu requested review from @mayra-cabrera and removed review request for @rliu-int

    requested review from @mayra-cabrera and removed review request for @rliu-int

  • Mayra Cabrera approved this merge request

    approved this merge request

  • Mayra Cabrera removed review request for @mayra-cabrera

    removed review request for @mayra-cabrera

  • Payton Burdette approved this merge request

    approved this merge request

  • requested review from @anna_vovchenko

  • Payton Burdette removed review request for @pburdette

    removed review request for @pburdette

  • mentioned in issue #414033 (closed)

  • Julia Miocene approved this merge request

    approved this merge request

  • Anna Vovchenko approved this merge request

    approved this merge request

  • Anna Vovchenko resolved all threads

    resolved all threads

  • Anna Vovchenko enabled an automatic merge when the pipeline for a3956bcf succeeds

    enabled an automatic merge when the pipeline for a3956bcf succeeds

  • Contributor

    :warning: @dstull Some end-to-end (E2E) tests have been selected based on the stage label on this MR. If not run already, please run the e2e:package-and-test-ee job in the qa stage and review the results before merging this MR. (E2E tests are not run automatically on some MRs due to runner resource constraints.)

    If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and restart the pipeline.

    Once done, please apply the :white_check_mark: emoji on this comment.

    For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.

  • merged

  • Anna Vovchenko mentioned in commit 3ddf1a86

    mentioned in commit 3ddf1a86

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading