Finish BigInt column swap for self-hosted installations

What does this MR do and why?

Finish BigInt column swap for self-hosted installations

UP:

main: == [advisory_lock_connection] object_id: 228440, pg_backend_pid: 50289
main: == [advisory_lock_connection] object_id: 228440, pg_backend_pid: 50289
ci: == [advisory_lock_connection] object_id: 228580, pg_backend_pid: 50292
ci: == 20230613192703 EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts: migrating
ci: -- The migration is skipped since it modifies the schemas: [:gitlab_main].
ci: -- This database can only apply migrations in one of the following schemas: [:gitlab_ci, :gitlab_internal, :gitlab_shared].
ci: == 20230613192703 EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts: migrated (0.0119s)

ci: == 20230613192802 SwapCiBuildNeedsToBigIntForSelfHosts: migrating =============
ci: == 20230613192802 SwapCiBuildNeedsToBigIntForSelfHosts: migrated (0.0115s) ====

ci: == [advisory_lock_connection] object_id: 228580, pg_backend_pid: 50292

❯ rails db:migrate:down:ci VERSION='20230613192703':

ci: == [advisory_lock_connection] object_id: 228120, pg_backend_pid: 61903
ci: == 20230613192703 EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts: reverting
ci: -- The migration is skipped since it modifies the schemas: [:gitlab_main].
ci: -- This database can only apply migrations in one of the following schemas: [:gitlab_ci, :gitlab_internal, :gitlab_shared].
ci: == 20230613192703 EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts: reverted (0.0097s)

ci: == [advisory_lock_connection] object_id: 228120, pg_backend_pid: 61903

❯ rails db:migrate:down:ci VERSION='20230613192802':

ci: == [advisory_lock_connection] object_id: 227740, pg_backend_pid: 62330
ci: == 20230613192802 SwapCiBuildNeedsToBigIntForSelfHosts: reverting =============
ci: == 20230613192802 SwapCiBuildNeedsToBigIntForSelfHosts: reverted (0.0082s) ====

ci: == [advisory_lock_connection] object_id: 227740, pg_backend_pid: 62330

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

Resolves: #415390 (closed)

assigned to @lauraX

added database databasereview pending labels

	2 Warnings
	New migrations added but db/structure.sql wasn't updated Usually, when adding new migrations, db/structure.sql should be updated too (unless the migration isn't changing the DB schema and isn't the most recent one).
	There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add the feature flagexists. Otherwise, if you think the changes here don't need to be under a feature flag, please add the label feature flagskipped, and add a short comment about why we skipped the feature flag. For guidance on when to use a feature flag, please see the documentation.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Marcos Rocha (@mc_rocha) (UTC-4, 6 hours behind @lauraX)	Peter Leitzen (@splattael) (UTC+2, same timezone as @lauraX)
database	Doug Stull (@dstull) (UTC-4, 6 hours behind @lauraX)	Diogo Frazão (@dfrazao-gitlab) (UTC+2, same timezone as @lauraX)
~"migration"	No reviewer available	No maintainer available
~"Verify"	Reviewer review is optional for ~"Verify"	Drew Cimino (@drew) (UTC+0, 2 hours behind @lauraX)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

• abf8ef48 - Finish BigInt column swap for self-hosted

Compare with previous version

added 1 commit

• a3259f0f - Finish BigInt column swap for self-hosted

Compare with previous version

mentioned in issue gitlab-org/ci-cd/pipeline-authoring#97 (closed)

Setting label grouppipeline authoring based on @lauraX's group.

added grouppipeline authoring label

changed the description

added devopsverify sectionci labels

added 520 commits

• a3259f0f...08e76d89 - 519 commits from branch master
• 3a7dbbea - Finish BigInt column swap for self-hosted

Compare with previous version

requested review from @krasio

added 1 commit

• 9b4792d2 - Finish BigInt column swap for self-hosted

Compare with previous version

marked this merge request as ready

changed title from Draft: Finish BigInt column swap for self-hosted to Finish BigInt column swap for self-hosted installs

changed title from Finish BigInt column swap for self-hosted installs to Finish BigInt column swap for self-hosted installations

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

changed the description

Hi @krasio - could you please review this MR for column swap for self-hosted? Thank yoU!

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for c82622c9

expand test summary

+------------------------------------------------------------+
|                       suites summary                       |
+-------+--------+--------+---------+-------+-------+--------+
|       | passed | failed | skipped | flaky | total | result |
+-------+--------+--------+---------+-------+-------+--------+
+-------+--------+--------+---------+-------+-------+--------+
| Total | 0      | 0      | 0       | 0     | 0     | ➖     |
+-------+--------+--------+---------+-------+-------+--------+

Setting label(s) Category:Pipeline Composition based on grouppipeline authoring.

added Category:Pipeline Composition label

mentioned in issue #415390 (closed)

mentioned in merge request !116924 (merged)

Database migrations (on the main database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20230613192703 - EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts	Post deploy	2.3 s		+0.00 B
20230613192802 - SwapCiBuildNeedsToBigIntForSelfHosts	Post deploy	1.4 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	4
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20230613192703 - EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts

• Type: Post deploy
• Duration: 2.3 s
• Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	2
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20230613192802 - SwapCiBuildNeedsToBigIntForSelfHosts

• Type: Post deploy
• Duration: 1.4 s
• Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for SwapCiBuildNeedsToBigIntForSelfHosts

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	2
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
database-testing-2058329-10442527-main	2023-06-26T23:07:39Z	2023-06-26T20:09:57Z	2023-06-27 11:11:51 +0000
database-testing-2058329-10442527-ci	2023-06-26T23:07:40Z	2023-06-26T20:46:29Z	2023-06-27 11:11:51 +0000

Job artifacts

Database migrations (on the ci database)

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20230613192703 - EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts	Post deploy	2.7 s		+0.00 B
20230613192802 - SwapCiBuildNeedsToBigIntForSelfHosts	Post deploy	2.2 s		+0.00 B

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	5
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20230613192703 - EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts

• Type: Post deploy
• Duration: 2.7 s
• Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
1	5.5 ms	5.5 ms	5.5 ms	1	SELECT "batched_background_migrations".* FROM "batched_background_migrations" WHERE "batched_background_migrations"."job_class_name" = $1 AND "batched_background_migrations"."table_name" = $2 AND "batched_background_migrations"."column_name" = $3 AND (job_arguments = $4) AND "batched_background_migrations"."gitlab_schema" IN ($5, $6, $7) ORDER BY "batched_background_migrations"."id" ASC LIMIT $8
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for EnsureCiBuildNeedsBigIntBackfillIsFinishedForSelfHosts

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	3
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Migration: 20230613192802 - SwapCiBuildNeedsToBigIntForSelfHosts

• Type: Post deploy
• Duration: 2.2 s
• Database size change: +0.00 B

Calls	Total Time	Max Time	Mean Time	Rows	Query
2	0.0 ms	0.0 ms	0.0 ms	2	SELECT pg_backend_pid()

Histogram for SwapCiBuildNeedsToBigIntForSelfHosts

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	2
0.1 seconds - 1 second	0
1 second - 5 seconds	0
5 seconds - 15 seconds	0
15 seconds - 5 minutes	0
5 minutes +	0

Other information

No other migrations pending on GitLab.com

Clone details

Clone ID	Clone Created At	Clone Data Timestamp	Expected Removal Time
database-testing-2058329-10442527-main	2023-06-26T23:07:39Z	2023-06-26T20:09:57Z	2023-06-27 11:11:51 +0000
database-testing-2058329-10442527-ci	2023-06-26T23:07:40Z	2023-06-26T20:46:29Z	2023-06-27 11:11:51 +0000

Job artifacts

---

Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic

added database-testing-automation label

added 1165 commits

• 9b4792d2...b69e8983 - 1163 commits from branch master
• 4c4c6052 - Finish BigInt column swap for self-hosted
• 5e6a5a9e - Updates gitlab_schema and ignores column

Compare with previous version

added 1 commit

• 8a9f101a - Updates gitlab_schema and ignores column

Compare with previous version

added backend label

added 1 commit

• f4a51be3 - Removes ignored_column

Compare with previous version

added 1 commit

• 159e8e8d - Updates gitlab_schema and ignores column

Compare with previous version

approved this merge request

@lauraX Thanks, looks good. Approving for database.

@ebaque can you please have a look and stamp this as backend maintainer?

added databaseapproved label and removed databasereview pending label

requested review from @ebaque and removed review request for @krasio

@krasio, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

added 1 commit

• c82622c9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

approved this merge request

requested review from @drew and removed review request for @ebaque

approved this merge request

added typemaintenance label

added maintenancescalability label

changed milestone to %16.2

resolved all threads

enabled an automatic merge when the pipeline for 3460e423 succeeds

merged

Hello @lauraX

The database team is looking for ways to improve the database review process and we would love your help!

If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:

@gitlab-org/database-team

And someone will be by shortly!

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit a6b9f4e4

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

mentioned in issue gitlab-org/database-team/team-tasks#354 (closed)

mentioned in issue #389344 (closed)

mentioned in merge request !126763 (merged)

added releasedcandidate label

mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)

mentioned in issue #419593 (closed)

mentioned in issue #421671 (closed)

mentioned in merge request !129456 (merged)

added releasedpublished label and removed releasedcandidate label

mentioned in issue #504348