Skip to content

Extract dimension selector constants from function

Elwyn Benson requested to merge visualization-designer-followup into master

What does this MR do and why?

Small follow up change from: !121624 (comment 1426638558)

Extract two constants form the function so they are not recomputed each time the function runs.

Screenshots or screen recordings

no visual / functional changes

How to set up and validate locally

  1. Follow these instructions to set up Product Analytics in your GDK.
  2. Enable the Snowplow flag by running the command: echo "Feature.enable(:product_analytics_snowplow_support)" | rails c.
  3. Enable the dashboard editor flag by running the command: echo "Feature.enable(:combined_analytics_dashboards_editor)" | rails c.
  4. Set up a new project and onboard it with Snowplow via Project → Analytics → Dashboards.
  5. Track some events and page views for the project via the SDK.
  6. Visit the visualization designer at Project → Analytics → Dashboards -> Visualization Designer and verify you can browse data and create visualizations.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports