Skip to content

Adds a max width to custom instance logos

Sam Beckham requested to merge fixed-custom-logo into master

What does this MR do and why?

This MR adds a max width to custom logos so they don't overflow and break the new nav. It's not the prettiest, and there's definitely better solutions, but it does the job for now.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-06-12_at_11.20.56 Screenshot_2023-06-12_at_11.20.43
Screenshot_2023-06-12_at_11.27.18 Screenshot_2023-06-12_at_11.27.18
Screenshot_2023-06-12_at_11.29.57 Screenshot_2023-06-12_at_11.27.53

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Run the GDK locally
  2. Go to Admin>personalization and change the logo to something with a super wide aspect ratio.
  3. Take a look.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sam Beckham

Merge request reports