Skip to content

Ignore selection if not in a table cell

Himanshu Kapoor requested to merge himkp-fix-table-cell-error into master

What does this MR do and why?

Ignore selection if not in a table cell

In content editor fix an error that preventing editing tables if cursor was outside tables.

Fixes error in console that prevents content editor from working completely when a table is in the issue/comment. Error was a regression caused by !121371 (merged).

image.png

Fixes: #414955 (closed)

Screenshots or screen recording

Before After

image.png

Rich text editor renders but it isn't functional. Clicking retry has no effect.

image.png

There is no error.

How to set up and validate locally

  1. Enable feature flag :content_editor_on_issues.
  2. Create a new issue. Switch to markdown editor.
  3. Use a template that has a table in it. Or write a new paragraph and insert a table next to it.
  4. Switch to rich text. It should no longer fail to render the rich text editor.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Himanshu Kapoor

Merge request reports