Add achievement icon padding

What does this MR do and why?

Add some padding in the user achievement icon.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

• Run the achievements seed script: bundle exec rake db:seed_fu FILTER=36_achievements
• Enable the feature flag in the rails console: Feature.enable(:achievements)
• Visit http://gdk.test:3000/root

If you have any problems, try deleting all achievements from the rails console: Achievements::Achievement.delete_all then re-running the seed script (not from the rails console): bundle exec rake db:seed_fu FILTER=36_achievements

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added Community contribution label

assigned to @gtsiolis

Hey @gtsiolis!

Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.

Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!

When you're ready for a first review, post @gitlab-bot ready. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with @gitlab-bot ready @user1 @user2.

At any time, if you need help, feel free to post @gitlab-bot help or initiate a mentor session on Discord. Read more on how to get help.

You can comment @gitlab-bot label <label1> <label2> to add labels to your MR. Please see the list of allowed labels in the label command documentation.

This message was generated automatically. You're welcome to improve it.

added workflowin dev label

added frontend label

	19 Warnings
	This MR has a Changelog commit for EE, but no code changes in ee/. Consider removing the EE: true trailer from your commits.
	2a7c777f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	d2e97473: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	0cdd3ecc: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	007d8224: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	ae1a8af8: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	cadc97f0: The commit subject and body must be separated by a blank line. For more information, take a look at our Commit message guidelines.
	b1cb0878: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	670f4d42: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	747c5ece: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	372f0ebd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	a14133d0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	95e90cf3: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	31141c5a: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	a42190a1: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits.
	This merge request does not refer to an existing milestone.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.
	Please add a merge request subtype to this merge request.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Ankit Panchal (@ankit.panchal) (UTC+5.5)	Vitaly Slobodin (@vitallium) (UTC+2)
UX	Mike Nichols (@mnichols1) (UTC-4)	Maintainer review is optional for UX

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 79b0b931 and b57f5857

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.18 MB	4.18 MB	-	0.0 %
mainChunk	3.09 MB	3.09 MB	-	0.0 %

---

Note: We do not have exact data for 79b0b931. So we have used data from: cee7aacb.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

@tbulva What do you think of this change?

Cc @leetickett-gitlab because !113156 (merged)

Cc @Taucher2003 because !119384 (merged)

requested review from @tbulva

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for b57f5857

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 6     | 9     | ❗     |
| Plan             | 4      | 0      | 0       | 4     | 4     | ❗     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 1     | 4     | ❗     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 21     | 0      | 2       | 11    | 23    | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: test report for b57f5857

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 20     | 0      | 3       | 0     | 23    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

mentioned in issue gitlab-org/quality/triage-reports#12778 (closed)

approved this merge request

@tbulva, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

requested review from @iamphill

removed review request for @tbulva

mentioned in issue gitlab-org/quality/triage-reports#12795 (closed)

removed review request for @iamphill

added UX label

Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.

This message was generated automatically. You're welcome to improve it.

requested review from @aregnery

added Category:User Profile grouptenant scale user profile labels

added devopsdata stores sectioncore platform labels

changed the description

added typemaintenance label

mentioned in epic &9429

changed the description

added 1328 commits

• 73851552...e0a3414f - 1327 commits from branch master
• bb1856a9 - Update achievement icon style

Compare with previous version

approved this merge request

removed review request for @aregnery

@gtsiolis, it seems we're waiting on an action from you for approximately two weeks.

• Do you still have capacity to work on this? If not, you might want to close this MR and/or ask someone to take over.
• Do you need help in getting it ready? At any time, you can:
  • ask for help with @gitlab-bot help.
  • initiate a mentor session on Discord.
• If you're actually ready for a review, you can post @gitlab-bot ready.

This message was generated automatically. You're welcome to improve it.

added automation:author-reminded label

added idle label

@f_caplette could you do the maintainer review for this? It was approved by UX here but has stalled as we need a maintainer to review.

requested review from @f_caplette

removed idle label

resolved all threads

added 3927 commits

• bb1856a9...2f2aac3b - 3926 commits from branch master
• b57f5857 - Merge branch 'master' into 'gt/add-ahievement-padding'

Compare with previous version

FYI I've fixed the conflict @gtsiolis. We switched from img to gl-avatar so I've just applied your classes to that component instead.

approved this merge request

resolved all threads

resolved all threads

mentioned in issue #414321 (closed)

mentioned in issue Taucher2003/reporting#34 (closed)

resolved all threads

merged

@leetickett-gitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

1. Ensure the merge request is not in Draft status.
2. Start a pipeline (especially important for Community contribution merge requests).
3. Set the merge request to auto-merge.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.

@gtsiolis, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

1. React with a or a on this comment to describe your experience.
2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

Interested in learning more tips and tricks to solve your next challenge faster? Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.

Thanks for your help!

This message was generated automatically. You're welcome to improve it.

mentioned in commit 13ac86c2