Skip to content

Fix HllRedisCounter overwriting know events aggregation with symbol instead of string (backport)

Related to #414253 (closed)

master bug fix !122625 (merged)

Description from the fix:

HllRedicsCounter caches known events at class level, that mean that overwritten attribute persists between multiple metrics. Because symbols were used to overwrite aggregation attribute to weekly, and it was persisted later on in aggregated metrics calculation some events had aggregation configured with symbols and other string, causing events.all? { |event| event[:aggregation] == aggregation } to return false and raise error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • This MR has a severity label assigned (if applicable).
  • Ensure the e2e:package-and-test job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

The process of backporting bug fixes into stable branches is tracked as part of an internal pilot. If you have questions about this process, please:

Edited by Mikołaj Wawrzyniak

Merge request reports

Loading