Skip to content

Error Tracking: Remove ingestion API

Peter Leitzen requested to merge pl-error-tracking-ingestion-api-404 into master

What does this MR do and why?

The Postgres backend was disabled in %14.9 and re-introduced with a Clickhouse backend in %16.0. See https://about.gitlab.com/releases/2023/05/22/gitlab-16-0-released/#error-tracking-is-now-generally-available

Contributes to #414933.

Other parts of this backend (as such services, models) are removed in follow-up MRs.

Refs #353956 (comment 1422068659)

MR navigation

Breaking change?

According to https://docs.gitlab.com/ee/development/api_styleguide.html#exceptions removing this API endpoint is a breaking change:

Exceptions

The exception is only when:

  • A feature must be removed in a major GitLab release.
  • Backward compatibility cannot be maintained in any form.

However, in %14.9 (via https://about.gitlab.com/releases/2022/03/22/gitlab-14-9-released/#release-removals) we've already announced this breaking change due to database performance issues.

  1. This endpoint was disabled for self-managed since then (behind a undocumented feature flag).
    • This endpoint returned 404 Not Found.
  2. The alternative Sentry was suggested.
  3. This endpoint was enabled again on GitLab.com on by accident to control the Observability backend.
  4. This endpoint always returned 404 Not Found on self-managed instances.

For this reasons I believe removing this endpoint is not a breaking change and can be done in a minor release.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Leitzen

Merge request reports