Localizing the date in the enforcement banner
What does this MR do and why?
This is a follow-up from !122964 (comment 1422781252):
One suggestion, though, it would be best if the finish date of the offer was localized. The date format
YYYY-MM-DD
is certainly our standard, but it may be more easily understood if it was localized.
From @dstull
:
you can use this if you desire
offer_date: l(Date.new(2023, 8, 13), format: Date::DATE_FORMATS[:medium])
and then replace that date in the text with%{offer_date}
this would mean a change to the gitlab.pot file too https://docs.gitlab.com/ee/development/i18n/externalization.html#dates--times
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.