Skip to content

Show failed jobs in MR pipelines tab part 4

Frédéric Caplette requested to merge fc-add-failed-jobs-in-mr-part-4 into master

What does this MR do and why?

Add failed jobs tract to MR pipelines tab

Behind a FF we add the ability to see failed jobs trace directly inside the pipelines tab of a MR. Failed jobs are only fetched when clicking on the button to expand the table. Then each failed jobs is fetched and can be clicked on to expand the job log and see why the job failed.

IMPORTANT Feature specs are also going to be written in the very last MR (or a separate MR, depending on size) to keep these really focus on FE only.

This is part 4 of 5 in a series of MR!

This MR simply adds the ability to retry failed jobs. When the retry is clicked, we fetch the whole list of jobs for now, so the entire list disappears, we show loading icon and the new list is shown again.

MR table:

Title Link
Introduce FF and base component !122914 (merged)
Fetch failed jobs !122917 (merged)
Display each failed job in a row with log !122921 (merged)
Add action button to each job row 👈🏻 You are here
Add polling when the widget is opened

this is behind a disabled feature flag: ci_job_failures_in_mr.

Screenshots or screen recordings

Before After
Screenshot_2023-06-07_at_10.59.57_AM Screenshot_2023-06-08_at_3.20.24_PM

Screen_Recording_2023-06-08_at_3.19.37_PM

How to set up and validate locally

  1. Enable feature flag in rails console `Feature.enable(:ci_job_failures_in_mr)
  2. Make sure to have a functioning runner
  3. We need a MR with jobs failures. An easy to do so is to make a merge request on the ci config file and add explicit failures
  4. Navigate to Build -> Pipeline Editor
  5. Change your config to include jobs failures like so:
my_failed_job:
  script: exit 1
  1. Create a merge request with that change
  2. Navigate to the Merge request page
  3. Go to the pipelines page
  4. Click on show failed jobs
  5. Notice the new retry actions. Note that they will be disabled if not available, not hidden (this was a deliberate choice on my part, but let's discuss this with UX 🌟 )
  6. Click on retry
  7. Notice the job is retried

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Frédéric Caplette

Merge request reports