Reset webpack path for Mermaid iFrames
Fixes #413596 (closed)
What does this MR do and why?
This MR sets correct webpack path for Mermaid iFrames to render it correctly. This was broken after this upgrade: !115885 (merged) possibly because it tries to load more chunks.
The sandbox iFrame loads on a separate origin which doesn't have access to gon.relative_url_root
to load the webpack chunk properly.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Spin up a GDK with a relative URL.
- Create an issue and adds a mermaid diagram to its description or comments.
- The diagram should now be generated correctly.
Example:
graph LR
A(GitLab Rails) -- Writes new pages deployment --> B[(NFS)]
C(GitLab Pages) -. Reads static content .-> B
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @djadmin
changed milestone to %16.1
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Diana Zubova (
@dzubova
) (UTC+2, 3.5 hours behind@djadmin
)Andrew Fontaine (
@afontaine
) (UTC-4, 9.5 hours behind@djadmin
)test for spec/features/*
Serhii Yarynovskyi (
@syarynovskyi
) (UTC+3, 2.5 hours behind@djadmin
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #413596 (closed)
- Resolved by Olena Horal-Koretska
@tbulva would you review this please?If you don't have any blocking concerns, would you mind passing this to @jerasmus for maintainer review? I can take up the non-blocking feedback in a separate MR if you don't mind.
Edited by Dheeraj Joshi
requested review from @tbulva
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a1f7a04d and 755eae01
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.13 MB 4.13 MB - 0.0 % mainChunk 2.99 MB 2.99 MB - 0.0 %
Note: We do not have exact data for a1f7a04d. So we have used data from: 69f88c32.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 755eae01expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 6 | 9 | ❗ | | Plan | 4 | 0 | 0 | 3 | 4 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 4 | 4 | ❗ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 13 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 755eae01expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 27 | 0 | 1 | 1 | 28 | ❗ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 3 | 1 | 42 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Tomas Bulva
removed review request for @tbulva
added 808 commits
-
7cd6eecd...e4f2632a - 807 commits from branch
master
- 8db07be0 - Reset webpack path for Mermaid iFrames
-
7cd6eecd...e4f2632a - 807 commits from branch
requested review from @tbulva
@tbulva would you take another look please?
@tbulva
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @ohoral
removed review request for @tbulva
added 607 commits
-
8db07be0...a85e1fd8 - 605 commits from branch
master
- 947f9b98 - Reset webpack path for Mermaid iFrames
- 145f7a70 - Add query params only when required
-
8db07be0...a85e1fd8 - 605 commits from branch
added 640 commits
-
145f7a70...1a9c2b62 - 638 commits from branch
master
- 6b6a1818 - Reset webpack path for Mermaid iFrames
- b7d8f737 - Add query params only when required
-
145f7a70...1a9c2b62 - 638 commits from branch
removed review request for @ohoral
added 76 commits
-
b7d8f737...5d805022 - 74 commits from branch
master
- 8604c595 - Reset webpack path for Mermaid iFrames
- a0066680 - Fix rspec by using absolute url
-
b7d8f737...5d805022 - 74 commits from branch
- Resolved by Dheeraj Joshi
requested review from @jay_mccure
changed milestone to %16.2
added missed:16.1 label
requested review from @ohoral and removed review request for @jay_mccure
enabled an automatic merge when the pipeline for 99d89a4a succeeds
mentioned in commit 1bef025d
picked the changes into the branch
cherry-pick-1bef025d
with commit 88da3f89mentioned in commit 88da3f89
mentioned in merge request !124613 (merged)
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label