Skip to content
Snippets Groups Projects

Reset webpack path for Mermaid iFrames

Merged Dheeraj Joshi requested to merge djadmin-fix-mermaid-relative-path into master
All threads resolved!

Fixes #413596 (closed)

What does this MR do and why?

This MR sets correct webpack path for Mermaid iFrames to render it correctly. This was broken after this upgrade: !115885 (merged) possibly because it tries to load more chunks.

The sandbox iFrame loads on a separate origin which doesn't have access to gon.relative_url_root to load the webpack chunk properly.

Screenshots or screen recordings

Before After
image image

How to set up and validate locally

  1. Spin up a GDK with a relative URL.
  2. Create an issue and adds a mermaid diagram to its description or comments.
  3. The diagram should now be generated correctly.

Example:

graph LR
  A(GitLab Rails) -- Writes new pages deployment --> B[(NFS)]
  C(GitLab Pages) -. Reads static content .-> B

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dheeraj Joshi

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomas Bulva removed review request for @tbulva

    removed review request for @tbulva

  • Dheeraj Joshi added 808 commits

    added 808 commits

    Compare with previous version

  • Dheeraj Joshi requested review from @tbulva

    requested review from @tbulva

  • Author Maintainer

    @tbulva would you take another look please?

  • Tomas Bulva resolved all threads

    resolved all threads

  • Tomas Bulva approved this merge request

    approved this merge request

  • :wave: @tbulva, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Tomas Bulva requested review from @ohoral

    requested review from @ohoral

  • Tomas Bulva removed review request for @tbulva

    removed review request for @tbulva

  • Dheeraj Joshi added 607 commits

    added 607 commits

    Compare with previous version

  • Dheeraj Joshi added 640 commits

    added 640 commits

    Compare with previous version

  • Dheeraj Joshi removed review request for @ohoral

    removed review request for @ohoral

  • Dheeraj Joshi added 76 commits

    added 76 commits

    Compare with previous version

  • Dheeraj Joshi requested review from @jay_mccure

    requested review from @jay_mccure

  • 🤖 GitLab Bot 🤖 changed milestone to %16.2

    changed milestone to %16.2

  • Dheeraj Joshi added 1 commit

    added 1 commit

    Compare with previous version

  • Dheeraj Joshi added 1 commit

    added 1 commit

    Compare with previous version

  • Jay McCure approved this merge request

    approved this merge request

  • Dheeraj Joshi requested review from @ohoral and removed review request for @jay_mccure

    requested review from @ohoral and removed review request for @jay_mccure

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Olena Horal-Koretska approved this merge request

    approved this merge request

  • Olena Horal-Koretska enabled an automatic merge when the pipeline for 99d89a4a succeeds

    enabled an automatic merge when the pipeline for 99d89a4a succeeds

  • mentioned in commit 1bef025d

  • Dheeraj Joshi picked the changes into the branch cherry-pick-1bef025d with commit 88da3f89

    picked the changes into the branch cherry-pick-1bef025d with commit 88da3f89

  • mentioned in commit 88da3f89

  • Dheeraj Joshi mentioned in merge request !124613 (merged)

    mentioned in merge request !124613 (merged)

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading