Skip to content

Fix actor-based rollout for `ci_vueify_inherited_group_variables` FF

Mireya Andres requested to merge ma/fix-ff-incremental-rollout into master

What does this MR do and why?

There was an issue with verifying changes when the ci_vueify_inherited_group_variables feature flag is enabled on specific projects. This MR fixes how the FF is checked on an actor (project) basis.

This is for enabling !119026 (merged) (migrates the inherited CI Variables table to vue).

I disabled the FF on gitlab projects in production for now slack ref.

Screenshots or screen recordings

after

How to set up and validate locally

  1. Enable the ci_vueify_inherited_group_variables feature flag for a specific project only. (Feature.enable(:ci_vueify_inherited_group_variables, Project.find(<project_id>)))
  2. Create a project in a subgroup of a group.
  3. Go to Settings > CI/CD > Variables for both the subgroup and group and add some CI variables.
  4. Under the CI/CD Variables for the project, view the the Inherited Group Variables section.
  5. Verify the changes. The table should show the variable type, options column, and a link to the group or subgroup that owns that variable.
  6. Go to a project under the same group where the FF is not enabled. The table should only have three columns when rendered using the HAML template.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports