NOP GitlabSettings::Options#symbolize_keys!
What does this MR do and why?
NOP GitlabSettings::Options#symbolize_keys!
To avoid problems where code alters the GitlabSettings::Options
internal hash keys, make it a No Operation method and raise an exception
in test and development mode.
Context
The original intent was to replace the internal hash with HashWithIndifferentAccess
, but it break a few flows on the initialization. So, for a first iteration, I'm decided to do the NOP on symbolize_keys!
/deep_symbolize_keys!
Related to: #413017 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.