Skip to content

Fix various bugs in project integrations API

Marin Hannache requested to merge mareo/gitlab:improve-integration-api into master

What does this MR do and why?

This MR fixes various bugs in the project integration API:

  • Fix missing fields in Discord integration update endpoint
  • Fix broken update of slack integration deployment_channel field (#28903)
  • Fix missing deployment_events field in project integration responses (#28903, #196575)
  • Fix broken update for confidential_note_channel (#23479, #28903 (comment 272724550))
  • Fix missing alert_channel and alert_events (#196575)
  • Fix broken update for job_events and commit_events (#196573)

Fixes #28903 #23479 #196575 #196573

Fixes most of the remaining issues highlighted in &2411

How to set up and validate locally

Missing fields in Discord integration update endpoint

  1. Try changing the notify_only_broken_pipelines or push_events fields on the /api/v4/projects/$PROJECT_ID/integrations/discord endpoint.

Broken update of slack integration deployment_channel field

  1. Try changing the deployment_channel fields on the /api/v4/projects/$PROJECT_ID/integrations/slack endpoint.

Fix missing deployment_events field in project integration responses

  1. Fetch /api/v4/projects/$PROJECT_ID/integrations/slack endpoint.
  2. Verify that deployment_events is present.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marin Hannache

Merge request reports