Remove direct data manipulation from selection_summary_spec
What does this MR do and why?
Describe in detail what your merge request does and why.
This MR resolves #413384 (closed)
What was cleaned up from epic:
- Remove
direct data manipulation
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
NO VISUAL CHANGES
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout branch
- Run test locally
- Or just check in pipeline
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #391041 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @arfedoro
- Resolved by Artur Fedorov
@robyrne could you please review this MR?
requested review from @robyrne
Setting label(s) Category:Security Policy Management based on groupsecurity policies.
added Category:Security Policy Management label
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Payton Burdette (
@pburdette
) (UTC-4, 6 hours behind@arfedoro
)Vitaly Slobodin (
@vitallium
) (UTC+2, same timezone as@arfedoro
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @vitallium and removed review request for @robyrne
mentioned in commit 17a7cb0d
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label