Skip to content

Migrate WebIDELink to GlDisclosureDropdown

What does this MR do and why?

It replaces GlDropdown with GlDisclosureDropdown in the component that allows opening a project or a file in the Web IDE, GitPod, or the Single File Editor. As a result of this replacement, the "Edit" button also behaves differently:

  • Instead of selecting a preferred editor, the user should always expand the "Edit" dropdown.
  • The dropdown doesn’t remember the user’s preferred editor anymore.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Page Before After
Repository view before_one.png after_one.png
Single file viewer when opening a gitlab-ci.yml file before_two.png after_two.png
Single file viewer when opening an arbitrary file before_three.png after_three.png

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

You can test this dropdown in three places:

  1. Repository view
  2. Single File View.

In the Single File View, you will see the Pipeline editor option when you open gitlab-ci.yml.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #395517 (closed)

Edited by Enrique Alcántara

Merge request reports