Skip to content
Snippets Groups Projects

Follow-up: Fix spec violations in add_edit_schedule_modal_spec.js

Merged Paulina Sedlak-Jakubowska requested to merge 413340-fix-spec-violations-follow-up into master
All threads resolved!

What does this MR do and why?

Following up on:

  1. Replace createLocalVue with Vue.use(VueApollo);
  2. Cover different UI states with new checks: buttons, alert dismissal, copy changing for create/edit mode

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-06-05_at_16.29.19 Screenshot_2023-06-06_at_12.42.03

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Checkout the branch locally and run yarn jest ee/spec/frontend/oncall_schedule/add_edit_schedule_modal_spec.js

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413340 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Paulina Sedlak-Jakubowska marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Paulina Sedlak-Jakubowska changed the description

    changed the description

  • requested review from @slashmanov

  • Stanislav Lashmanov
  • Stanislav Lashmanov
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Stanislav Lashmanov approved this merge request

    approved this merge request

  • Stanislav Lashmanov requested review from @aturinske and removed review request for @slashmanov

    requested review from @aturinske and removed review request for @slashmanov

  • Alexander Turinske
  • Alexander Turinske resolved all threads

    resolved all threads

  • Alexander Turinske approved this merge request

    approved this merge request

  • Alexander Turinske enabled an automatic merge when the pipeline for 265ea478 succeeds

    enabled an automatic merge when the pipeline for 265ea478 succeeds

  • mentioned in commit 3ae8bf3a

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading