Follow-up: Fix spec violations in add_edit_schedule_modal_spec.js
What does this MR do and why?
Following up on:
- Replace
createLocalVue
withVue.use(VueApollo);
- Cover different UI states with new checks: buttons, alert dismissal, copy changing for create/edit mode
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout the branch locally and run
yarn jest ee/spec/frontend/oncall_schedule/add_edit_schedule_modal_spec.js
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413340 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @psjakubowska
added sectionsec label and removed sectionops label
added docs-only label
- Resolved by Alexander Turinske
1 Warning This merge request contains lines with QA selectors. Please ensure e2e:package-and-test
job is run.QA Selectors
The following changed lines in this MR contain QA selectors:
- file
ee/spec/frontend/oncall_schedule/add_edit_schedule_modal_spec.js
: -
-
'data-qa-selector': 'add_schedule_button',
-
Please ensure
e2e:package-and-test
job is run and the tests are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Ammar Alakkad (
@aalakkad
) (UTC+3, 1 hour ahead of@psjakubowska
)Alexander Turinske (
@aturinske
) (UTC+9, 7 hours ahead of@psjakubowska
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger - file
removed docs-only label
- Resolved by Alexander Turinske
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @slashmanov
- Resolved by Stanislav Lashmanov
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
- Resolved by Alexander Turinske
requested review from @aturinske and removed review request for @slashmanov
- Resolved by Alexander Turinske
enabled an automatic merge when the pipeline for 265ea478 succeeds
mentioned in commit 3ae8bf3a
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#246 (closed)
mentioned in issue gitlab-org/monitor/respond#247 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label