Fix spec violations in delete_rotation_modal_spec.js
What does this MR do and why?
- get rid of mocking
data()
- use preferred way for mocking Apollo
- unify
createComponent
and duplicated assertions - general refactor
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Checkout the branch locally and run:
yarn jest ee/spec/frontend/oncall_schedule/rotations/components/delete_rotation_modal_spec.js
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413319 (closed)
Merge request reports
Activity
assigned to @psjakubowska
added workflowin dev label and removed workflowready for development label
- Resolved by David Pisek
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 3.5 hours ahead of@psjakubowska
)Anna Vovchenko (
@anna_vovchenko
) (UTC+3, 1 hour ahead of@psjakubowska
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
requested review from @a_akgun
added workflowin review label and removed workflowin dev label
added sectionsec label and removed sectionops label
changed milestone to %16.1
- Resolved by David Pisek
- Resolved by David Pisek
- Resolved by David Pisek
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
mentioned in commit a4ebf44f
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#247 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label