Skip to content
Snippets Groups Projects

Add snippet url to webhook payload

What does this MR do and why?

Add snippet url to webhook payload

All other type of note event payloads had a url in them except for snippet.

Changelog: added

Screenshots or screen recordings

image

How to set up and validate locally

  1. Add a webhook on this link to capture events. Make sure to check Comments in the Trigger section to receive comment events.
  2. Create a new snippet and comment on it.
  3. Check the logs at this link. Click on Edit next to the created webhook in Step 1
  4. Scroll down to see the latest webhook and click on Recent Details. You should see the added url field inside snippet

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Satyam Bansal

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Evan Read changed milestone to %16.1

    changed milestone to %16.1

  • added docsfeature label

  • A deleted user added backend label

    added backend label

  • Contributor
    1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Harsimar Sandhu current availability (@harsimarsandhu) (UTC+5.5) Jessie Young current availability (@jessieay) (UTC+8)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Evan Read removed review request for @eread

    removed review request for @eread

  • Luke Duncalfe
  • Luke Duncalfe requested review from @.luke

    requested review from @.luke

  • added featureaddition label and removed featureenhancement label

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 9d0c4c5e

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Luke Duncalfe
  • Luke Duncalfe
  • Luke Duncalfe
  • added workflowin dev label and removed workflowready for review label

  • Luke Duncalfe removed review request for @.luke

    removed review request for @.luke

  • Satyam Bansal added 1 commit

    added 1 commit

    • 9d0c4c5e - Add snippet url to webhook payload

    Compare with previous version

  • 🤖 GitLab Bot 🤖 requested review from @.luke

    requested review from @.luke

  • @.luke, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author.

    This message was generated automatically. You're welcome to improve it.

  • Evan Read approved this merge request

    approved this merge request

  • Luke Duncalfe approved this merge request

    approved this merge request

  • Luke Duncalfe requested review from @lulalala and removed review request for @.luke

    requested review from @lulalala and removed review request for @.luke

  • Mark Chao approved this merge request

    approved this merge request

  • Mark Chao resolved all threads

    resolved all threads

  • Mark Chao enabled an automatic merge when the pipeline for 81cc2db6 succeeds

    enabled an automatic merge when the pipeline for 81cc2db6 succeeds

  • Bojan Marjanovic resolved all threads

    resolved all threads

  • Bojan Marjanovic approved this merge request

    approved this merge request

  • merged

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading