Tidy up specs that dont need a diff to be created
Now that we have the variable 'skip_ensure_merge_request_diff` we can remove the special class we were using to stop the creation of a diff.
Merge request reports
Activity
changed milestone to %16.1
added backend maintenancerefactor labels
assigned to @marc_shaw
added typemaintenance label
added 1 commit
- b62c84fe - Use the variable rather than a purpose class to skip diff creation
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Pedro Pombeiro (
@pedropombeiro
) (UTC+2, same timezone as@marc_shaw
)Sincheol (David) Kim (
@dskim_gitlab
) (UTC+9.5, 7.5 hours ahead of@marc_shaw
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !118812 (merged)
Setting label groupcode review based on
@marc_shaw
's group.added groupcode review label
Setting label(s) devopscreate sectiondev based on groupcode review.
added devopscreate sectiondev labels
added 669 commits
-
b62c84fe...8c897532 - 668 commits from branch
master
- 9239d53a - Use the variable rather than a purpose class to skip diff creation
-
b62c84fe...8c897532 - 668 commits from branch
added 1 commit
- 5f57e8f5 - Use the variable rather than a purpose class to skip diff creation
- Resolved by Sincheol (David) Kim
@dskim_gitlab Mind taking a review here?
requested review from @dskim_gitlab
enabled an automatic merge when the pipeline for 72aa17f4 succeeds
mentioned in commit 63022a9c
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label