Skip to content
Snippets Groups Projects

Ensure instance admins can admin service accounts

Merged Drew Blessing requested to merge dblessing_service_account_policy_update into master

What does this MR do and why?

Adds admins to the :admin_service_accounts group policy permission to ensure instance admins can act as group owners when admin mode is enabled.

This came up while Eduardo is working on !121065 (merged)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

s

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :wave: @dblessing, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.

    This nudge was added by this triage-ops policy.

  • Aboobacker MK approved this merge request

    approved this merge request

  • :wave: @tachyons-gitlab, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Aboobacker MK requested review from @ifarkas and removed review request for @tachyons-gitlab

    requested review from @ifarkas and removed review request for @tachyons-gitlab

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for e0890414

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Plan             | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 1     | 2     | ❗     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 21     | 0      | 2       | 1     | 23    | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Imre Farkas resolved all threads

    resolved all threads

  • Imre Farkas approved this merge request

    approved this merge request

  • Imre Farkas resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading