Skip to content

Fail product analytics initialization after 2 sidekiq failures

Max Woolf requested to merge 413629-snowplow-initialization-failure into master

What does this MR do and why?

Fails product analytics initialization after 2 sidekiq failures

Since the sidekiq job relies on an external service that is owned and maintained by GitLab, this removes the lock on the background job after just 1 retry to give the user quicker feedback on an unlikely failure.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

  • Make sure snowplow support is enabled. (:product_analytics_snowplow_support)
  • Try to initialize a project with the product analytics stack where something is broken. I would just put in a broken URL in the admin settings for the snowplow configurator.
  • Wait a couple of minutes.
  • Reload the page, try to initialize the stack again and note that it tries again and doesn't show the "stack is already initializing" error.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413629 (closed) and !122208 (merged)

Edited by Max Woolf

Merge request reports