Remove password_reset_any_verified_email FF
What does this MR do and why?
It removes password_reset_any_verified_email
. The FF was enabled by default in !120971 (merged), no problems reported.
Screenshots or screen recordings
How to set up and validate locally
- Go to your profile email settings (eg. http://localhost:3000/-/profile/emails) and check that besides a primary email you have at least one verified and one unverified email (root user from seed complies with this criteria)
- Sign out and go to forgot your password page (eg. http://localhost:3000/users/password/new)
- Enter the primary email and check you received an email (http://localhost:3000/rails/letter_opener)
- Check the
To
email address is the same as the email you entered in the form - This worked already before this change
- Check the
- Enter one of the secondary verified emails and check you received an email
- Check the
To
email address is the same as the email you entered in the form - This is a new functionality and should not work on master
- Check the
- Enter one of the secondary unverified emails and check if you received an email. You should not receive one
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #410038 (closed)
Merge request reports
Activity
changed milestone to %16.1
assigned to @jarka
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Eugie Limpin (
@eugielimpin
) (UTC+8, 6 hours ahead of@jarka
)Max Woolf (
@mwoolf
) (UTC+1, 1 hour behind@jarka
)frontend Deepika Guliani (
@deepika.guliani
) (UTC+5.5, 3.5 hours ahead of@jarka
)Ezekiel Kigbo (
@ekigbo
) (UTC+10, 8 hours ahead of@jarka
)test for spec/features/*
Andrejs Cunskis (
@acunskis
) (UTC+3, 1 hour ahead of@jarka
)Maintainer review is optional for test for spec/features/*
~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Małgorzata Ksionek (
@mksionek
) (UTC+2, same timezone as@jarka
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@272dadab
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a935d28fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for a935d28fexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 224 | 0 | 17 | 11 | 241 | ❗ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Create | 16 | 0 | 27 | 0 | 43 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 265 | 0 | 46 | 11 | 311 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Luke Duncalfe
@jessieay could you please review for backend and also as a ~"group::authentication and authorization" Engineer?
@deepika.guliani could you please review frontend part?
requested review from @jessieay and @deepika.guliani
@jarka, please can you answer the question: Should this have a feature flag? to help with code review for the Authentication and Authorization group.This nudge was added by this triage-ops policy.
requested review from @ntepluhina and removed review request for @deepika.guliani
@deepika.guliani
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@54903e06
removed review request for @ntepluhina
requested review from @.luke
removed review request for @jessieay
- Resolved by Luke Duncalfe
@jarka Thank you! Looks great. Set to merge when the pipeline succeeds
!enabled an automatic merge when the pipeline for 97c71012 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@97c71012
mentioned in commit 96069fb3
mentioned in merge request gitlab-com/www-gitlab-com!122785 (merged)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2224 (merged)
added releasedpublished label and removed releasedcandidate label