Skip to content
Snippets Groups Projects

Remove password_reset_any_verified_email FF

Merged Jarka Košanová requested to merge 410038-remove-ff into master
All threads resolved!

What does this MR do and why?

It removes password_reset_any_verified_email . The FF was enabled by default in !120971 (merged), no problems reported.

Screenshots or screen recordings

How to set up and validate locally

  1. Go to your profile email settings (eg. http://localhost:3000/-/profile/emails) and check that besides a primary email you have at least one verified and one unverified email (root user from seed complies with this criteria)
  2. Sign out and go to forgot your password page (eg. http://localhost:3000/users/password/new)
  3. Enter the primary email and check you received an email (http://localhost:3000/rails/letter_opener)
    • Check the To email address is the same as the email you entered in the form
    • This worked already before this change
  4. Enter one of the secondary verified emails and check you received an email
    • Check the To email address is the same as the email you entered in the form
    • This is a new functionality and should not work on master
  5. Enter one of the secondary unverified emails and check if you received an email. You should not receive one

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #410038 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Luke Duncalfe resolved all threads

    resolved all threads

  • @jarka Thank you! Looks great. Set to merge when the pipeline succeeds :rocket:!

  • Luke Duncalfe enabled an automatic merge when the pipeline for 97c71012 succeeds

    enabled an automatic merge when the pipeline for 97c71012 succeeds

  • merged

  • Luke Duncalfe mentioned in commit 96069fb3

    mentioned in commit 96069fb3

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading