Skip to content
Snippets Groups Projects

Delete unused cluster health tab UI code

Merged Tristan Read requested to merge tr-delete-cluster-health-tab-code into master
All threads resolved!

What does this MR do and why?

The cluster health tab was removed as part of the %16.0 removals.

This MR deletes the now-inactive frontend code.

issue: #393926 (closed)

Screenshots or screen recordings

No change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Apply the following diff to disable the feature flag and add a live debug point:

    Click to expand
    diff --git a/spec/features/clusters/cluster_detail_page_spec.rb b/spec/features/clusters/cluster_detail_page_spec.rb
    index 31dec5e38daf..be92fde08d4d 100644
    --- a/spec/features/clusters/cluster_detail_page_spec.rb
    +++ b/spec/features/clusters/cluster_detail_page_spec.rb
    @@ -11,6 +11,7 @@
    
       before do
         sign_in(current_user)
    +    stub_feature_flags(remove_monitor_metrics: false)
       end
    
       shared_examples 'show page' do
    @@ -23,6 +24,8 @@
         it 'allow the user to set domain', :js do
           visit cluster_path
    
    +      live_debug
    +
           within '.js-cluster-details-form' do
             fill_in('cluster_base_domain', with: 'test.com')
             click_on 'Save changes'
  2. Run the spec: bin/rspec spec/features/clusters/cluster_detail_page_spec.rb.

  3. When the browser window opens, use the command line user/password to log in and see the page.

  4. Observe that the 'Health' tab is removed from the cluster page and no errors are present.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Tristan Read

Merge request reports

Merged results pipeline #894275018 passed with warnings

Pipeline: GitLab

#894286311

    Pipeline: E2E GDK

    #894291320

      Pipeline: GitLab

      #894293935

        Merged results pipeline passed with warnings for 3853282a

        Test coverage 82.32% (13.32%) from 2 jobs
        Approved by

        Merged by Himanshu KapoorHimanshu Kapoor 1 year ago (Jun 8, 2023 8:50pm UTC)

        Merge details

        • Changes merged into master with 56e72781 (commits were squashed).
        • Deleted the source branch.
        • Auto-merge enabled

        Pipeline #894347415 passed

        Pipeline passed for 56e72781 on master

        Test coverage 66.63% (13.32%) from 2 jobs
        10 environments impacted.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • Sylvester Chin removed review request for @schin1

        removed review request for @schin1

      • Tristan Read added 1 commit

        added 1 commit

        Compare with previous version

      • Tristan Read added 1 commit

        added 1 commit

        • 6ec90f41 - Review feedback: Remove unneeded health dashboard spec

        Compare with previous version

      • Tristan Read added 2 commits

        added 2 commits

        • d2ed4a96 - Review feedback: Add detail view spec
        • 488ce0b8 - Review feedback: Remove unneeded health dashboard spec

        Compare with previous version

      • Tristan Read
      • Tristan Read requested review from @jarka

        requested review from @jarka

      • mentioned in issue #410520 (closed)

      • mentioned in issue #393926 (closed)

      • Himanshu Kapoor approved this merge request

        approved this merge request

      • :wave: @himkp, thanks for approving this merge request.

        This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

        For more info, please refer to the following links:

      • Jarka Košanová approved this merge request

        approved this merge request

      • Jarka Košanová removed review request for @jarka

        removed review request for @jarka

      • Himanshu Kapoor resolved all threads

        resolved all threads

      • Himanshu Kapoor enabled an automatic merge when the pipeline for 3853282a succeeds

        enabled an automatic merge when the pipeline for 3853282a succeeds

      • Himanshu Kapoor mentioned in commit 56e72781

        mentioned in commit 56e72781

      • added workflowstaging label and removed workflowcanary label

      • Please register or sign in to reply
        Loading