Delete unused cluster health tab UI code
What does this MR do and why?
The cluster health tab was removed as part of the %16.0 removals.
This MR deletes the now-inactive frontend code.
issue: #393926 (closed)
Screenshots or screen recordings
No change.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
-
Apply the following diff to disable the feature flag and add a live debug point:
Click to expand
diff --git a/spec/features/clusters/cluster_detail_page_spec.rb b/spec/features/clusters/cluster_detail_page_spec.rb index 31dec5e38daf..be92fde08d4d 100644 --- a/spec/features/clusters/cluster_detail_page_spec.rb +++ b/spec/features/clusters/cluster_detail_page_spec.rb @@ -11,6 +11,7 @@ before do sign_in(current_user) + stub_feature_flags(remove_monitor_metrics: false) end shared_examples 'show page' do @@ -23,6 +24,8 @@ it 'allow the user to set domain', :js do visit cluster_path + live_debug + within '.js-cluster-details-form' do fill_in('cluster_base_domain', with: 'test.com') click_on 'Save changes'
-
Run the spec:
bin/rspec spec/features/clusters/cluster_detail_page_spec.rb
. -
When the browser window opens, use the command line user/password to log in and see the page.
-
Observe that the 'Health' tab is removed from the cluster page and no errors are present.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @tristan.read
changed milestone to %16.1
added devopsmonitor sectionops labels
- A deleted user
added backend label
1 Warning be1ba565: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Sylvester Chin (
@schin1
) (UTC+8, 4 hours behind@tristan.read
)Jarka Košanová (
@jarka
) (UTC+2, 10 hours behind@tristan.read
)frontend Lorenz van Herwaarden (
@lorenzvanherwaarden
) (UTC+2, 10 hours behind@tristan.read
)Himanshu Kapoor (
@himkp
) (UTC+2, 10 hours behind@tristan.read
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/monitor/respond#244 (closed)
added 1 commit
- ed527bcb - Remove cluster health code from admin bundle
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5b70c851 and 488ce0b8
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.11 MB -30.52 KB -0.7 % mainChunk 2.99 MB 2.99 MB - 0.0 % Significant Reduction: 3Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.clusters.show 4.89 MB 301.14 KB -4.6 MB -94.0 % pages.projects.clusters.show 4.97 MB 374.65 KB -4.6 MB -92.6 % pages.admin.clusters.show 4.88 MB 290.74 KB -4.6 MB -94.2 %
Note: We do not have exact data for 5b70c851. So we have used data from: ef4bf4b4.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Himanshu Kapoor
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 488ce0b8expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 1 | 2 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 2 | 1 | 23 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 488ce0b8expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Plan | 2 | 1 | 1 | 0 | 4 | ❌ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Create | 6 | 2 | 1 | 0 | 9 | ❌ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 0 | 2 | 0 | 1 | 2 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 15 | 5 | 3 | 1 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added sectionsec label and removed sectionops label
added 1 commit
- 50598be8 - Revert "Remove cluster health dashboard specs"
added 1575 commits
-
50598be8...fd550d39 - 1567 commits from branch
master
- be1ba565 - Remove cluster health tab UI
- 4cc61556 - Remove groups cluster health tab frontend
- 8c16baa0 - Update locale.pot files
- 06619dfb - Remove cluster health code from admin bundle
- 08f0e8c0 - Update cluster health specs
- c88ce4bf - Remove cluster health dashboard specs
- 45e23b17 - Remove cluster tab spec
- 00f232a1 - Revert "Remove cluster health dashboard specs"
Toggle commit list-
50598be8...fd550d39 - 1567 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Himanshu Kapoor
@psjakubowska could you please give this a frontend review for me? Thanks!
requested review from @psjakubowska
requested review from @himkp and @schin1 and removed review request for @psjakubowska
- Resolved by Tristan Read
- Resolved by Tristan Read
removed review request for @schin1
added 1 commit
- 6ec90f41 - Review feedback: Remove unneeded health dashboard spec
- Resolved by Himanshu Kapoor
- Resolved by Himanshu Kapoor
requested review from @jarka
mentioned in issue #410520 (closed)
mentioned in issue #393926 (closed)
@himkp
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @jarka
enabled an automatic merge when the pipeline for 3853282a succeeds
mentioned in commit 56e72781
added workflowstaging-canary label
mentioned in issue gitlab-org/monitor/respond#246 (closed)
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/monitor/respond#247 (closed)
added releasedcandidate label
mentioned in issue gitlab-org/monitor/respond#250 (closed)
mentioned in issue gitlab-org/monitor/respond#251 (closed)
mentioned in issue gitlab-org/monitor/respond#252 (closed)
mentioned in issue gitlab-org/monitor/respond#254 (closed)
mentioned in issue gitlab-org/monitor/respond#259 (closed)
mentioned in issue gitlab-org/monitor/respond#260 (closed)
added releasedpublished label and removed releasedcandidate label